Skip to content

Commit 5f41bd2

Browse files
authored
Fix wrong import in data plugin causing 100kB bundle increase (#93448) (#93580)
# Conflicts: # api_docs/data.json # api_docs/data_search.json # src/plugins/data/common/search/search_source/search_source.ts
1 parent cedee32 commit 5f41bd2

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1344,7 +1344,7 @@ module.exports = {
13441344
'no-restricted-imports': [
13451345
'error',
13461346
{
1347-
patterns: ['lodash/*', '!lodash/fp'],
1347+
patterns: ['lodash/*', '!lodash/fp', 'rxjs/internal-compatibility'],
13481348
},
13491349
],
13501350
},

packages/kbn-optimizer/limits.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pageLoadAssetSize:
1414
dashboard: 374267
1515
dashboardEnhanced: 65646
1616
dashboardMode: 22716
17-
data: 1319839
17+
data: 900000
1818
dataEnhanced: 50420
1919
devTools: 38781
2020
discover: 105147

src/plugins/data/common/search/search_source/search_source.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,19 @@
5959
*/
6060

6161
import { setWith } from '@elastic/safer-lodash-set';
62-
import { uniqueId, keyBy, pick, difference, omit, isFunction, isEqual, uniqWith } from 'lodash';
62+
import {
63+
uniqueId,
64+
keyBy,
65+
pick,
66+
difference,
67+
isFunction,
68+
isEqual,
69+
uniqWith,
70+
isObject,
71+
omit,
72+
} from 'lodash';
6373
import { map, switchMap, tap } from 'rxjs/operators';
6474
import { defer, from } from 'rxjs';
65-
import { isObject } from 'rxjs/internal-compatibility';
6675
import { normalizeSortRequest } from './normalize_sort_request';
6776
import { fieldWildcardFilter } from '../../../../kibana_utils/common';
6877
import { IIndexPattern, IndexPattern, IndexPatternField } from '../../index_patterns';

0 commit comments

Comments
 (0)