Skip to content

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Mar 1, 2021

Summary

This PR makes small changes on the data frame analytics UI text to be in line with the UI writing guidelines.

Checklist

@szabosteve szabosteve added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Mar 1, 2021
@szabosteve szabosteve marked this pull request as ready for review March 1, 2021 14:43
@szabosteve szabosteve requested a review from a team as a code owner March 1, 2021 14:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@szabosteve szabosteve requested a review from lcawl March 1, 2021 14:44
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, otherwise LGTM!

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@szabosteve
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve merged commit 284a77c into elastic:master Mar 4, 2021
@szabosteve szabosteve deleted the dfa.ui.text branch March 4, 2021 08:09
szabosteve added a commit that referenced this pull request Mar 4, 2021
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
* master: (48 commits)
  Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448)
  [Fleet] Correctly track install status of an integration (elastic#93464)
  Reviews data frame analytics UI text (elastic#93033)
  Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280)
  [Security Solution][Detections] ML Popover overflow fix (elastic#93525)
  chore(NA): do not use execa on bazel workspace status update script (elastic#93532)
  Bump dependencies (elastic#93511)
  [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529)
  [Security Solution] fix data provider cypress test (elastic#93465)
  Fix service map for All environment single service (elastic#93517)
  [Fleet] Fix package version comparaison in the UI (elastic#93498)
  [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720)
  [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473)
  [core-new-docs] Adds a dev-doc for core documentation (elastic#92976)
  remove opacity from maps legacy style (elastic#93456)
  [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176)
  Revert "Make tests deterministic by providing unique timestamps (elastic#93350)"
  [Discover] Fix link from dashboard saved search to Discover (elastic#92937)
  update public api docs
  App Search - Polishing Analytics Views (elastic#92939)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants