[ts] enable "resolveJsonModule" and disable existing failures #78855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Sep 30, 2020
jloleysens
approved these changes
Sep 30, 2020
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
ES UI changes look good to me!
walterra
approved these changes
Sep 30, 2020
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
ML/Transform changes LGTM.
alexwizp
approved these changes
Sep 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 1, 2020
* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript has supported the
resolveJsonModulecompiler option since v2.9. We have tried to do this several times (#24425, #25516) and each time we weren't quite ready. The repo seems to be in a state now were we can enable this feature, get automatic type generation for JSON files, and identify places where JSON is outdated based on the expectations defined in the types (especially in tests). This feature is also needed for the Vega upgrade under way in #78390.Several existing JSON imports which were taking advantage of the fact that all JSON imports were using the
anytype. With these imports now getting types defined the flaws in either the JSON itself, or the automatically generated types, are causing type errors. In order to allow code owners to determine the correct action for the JSON in their code I've used@ts-expect-errordirectives to hide those errors.Once this PR is merged I'll create issues for each team to detail the work they should schedule to remove the expected error directives.