Skip to content

Conversation

@cnasikas
Copy link
Member

@cnasikas cnasikas commented Sep 29, 2020

Summary

Improves #73778 by adding the ability to select a parent issue when selecting Sub-task as issue type.

sub_task

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.10.0 labels Sep 29, 2020
@cnasikas cnasikas self-assigned this Sep 29, 2020
@cnasikas cnasikas marked this pull request as ready for review September 29, 2020 13:57
@cnasikas cnasikas requested a review from a team as a code owner September 29, 2020 13:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
triggers_actions_ui 272 +3 269

async chunks size

id value diff baseline
triggers_actions_ui 1.5MB +15.2KB 1.5MB

page load bundle size

id value diff baseline
triggers_actions_ui 147.5KB +1.5KB 145.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. 👍 It would be nice to have some UI tests for Jira x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui. I know that we don't have a coverage for each action type here, just only for the server API, but at least you can open a follow up issue to add some tests later.

@cnasikas cnasikas merged commit 3d9ea52 into elastic:master Oct 1, 2020
@cnasikas cnasikas deleted the actions_jira_subtask branch October 1, 2020 06:34
cnasikas added a commit to cnasikas/kibana that referenced this pull request Oct 1, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 1, 2020
* master: (36 commits)
  [I18n] fix eui tokens (elastic#78951)
  Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768)
  Make the actual Vislib import async (elastic#78949)
  Fix ML conditionals links Cypress tests (elastic#78568)
  [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761)
  [UX] Improve page-load axis (elastic#78392)
  [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610)
  Data plugin README (elastic#78750)
  [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009)
  fixing api test (elastic#78964)
  [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129)
  [Loggers] Rename "telemetry" to "usage" (elastic#78130)
  [Usage Collection] [schema] `ui_metric` (elastic#78827)
  [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772)
  [Discover] Unskip doc link functional test (elastic#78600)
  [ML] Functional tests - stabilize calendar edit tests (elastic#78950)
  [UX] Improve page responsive  (elastic#78759)
  [QA][Code Coverage] Team Assignment Docs Update (elastic#78890)
  [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra  (elastic#78209)
  [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants