Skip to content

Conversation

@kertal
Copy link
Member

@kertal kertal commented Sep 28, 2020

Summary

Unskipping Discover doc link functional test

This test doesn't seem to be flaky:
200 runs, just the test suite
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/859/
100 runs, oss:ciGroup:6
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/870/

Fixes #78373

Note that there are other test cases failed in a similar flaky way, Error loading data, like this

#39842

I've improved the error message to provide more info her:

#78587

Fixes #78373

@kertal kertal self-assigned this Sep 30, 2020
@kertal kertal added the Feature:Discover Discover Application label Sep 30, 2020
@kertal
Copy link
Member Author

kertal commented Sep 30, 2020

@elasticmachine merge upstream

@kertal kertal added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// :KibanaApp/fix-it-week v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 30, 2020
@kertal kertal marked this pull request as ready for review September 30, 2020 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal requested a review from spalger September 30, 2020 17:27
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kertal kertal merged commit ec9d220 into elastic:master Oct 1, 2020
kertal added a commit to kertal/kibana that referenced this pull request Oct 1, 2020
* Flaky test runner confirmed it's not flaky
kertal added a commit that referenced this pull request Oct 1, 2020
* Flaky test runner confirmed it's not flaky
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 1, 2020
* master: (36 commits)
  [I18n] fix eui tokens (elastic#78951)
  Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768)
  Make the actual Vislib import async (elastic#78949)
  Fix ML conditionals links Cypress tests (elastic#78568)
  [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761)
  [UX] Improve page-load axis (elastic#78392)
  [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610)
  Data plugin README (elastic#78750)
  [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009)
  fixing api test (elastic#78964)
  [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129)
  [Loggers] Rename "telemetry" to "usage" (elastic#78130)
  [Usage Collection] [schema] `ui_metric` (elastic#78827)
  [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772)
  [Discover] Unskip doc link functional test (elastic#78600)
  [ML] Functional tests - stabilize calendar edit tests (elastic#78950)
  [UX] Improve page responsive  (elastic#78759)
  [QA][Code Coverage] Team Assignment Docs Update (elastic#78890)
  [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra  (elastic#78209)
  [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0

Projects

None yet

4 participants