Skip to content

Conversation

@Miehau
Copy link

@Miehau Miehau commented Aug 9, 2020

Summary

Updates naming from 'Space privileges' to 'Kibana privileges' for english, japanese and chinese languages.

Summon @legrego
Closes #74526

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Miehau Miehau requested a review from a team as a code owner August 9, 2020 18:31
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Miehau Miehau marked this pull request as draft August 9, 2020 18:33
@Miehau Miehau changed the title Update space privileges to kibana privileges Update 'space privileges' to 'kibana privileges' Aug 9, 2020
@Miehau Miehau marked this pull request as ready for review August 9, 2020 18:39
@legrego legrego added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.0.0 v7.10.0 release_note:enhancement labels Aug 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego self-requested a review August 9, 2020 23:24
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Miehau, thanks for taking the time to put this PR together, we really appreciate it!

In addition to the title change you made, I think it'd also be a good idea to update the button text as well. This actually manifests itself in a number of places:

  1. Button text:

    <FormattedMessage
    id="xpack.security.management.editRole.spacePrivilegeSection.addSpacePrivilegeButton"
    defaultMessage="Add space privilege"
    />

  2. Corresponding test title:

  3. A number of documentation references in this file should be renamed to reflect the updated button text (a quick find of "Add space privilege" in this file will assist):

    To assign {kib} privileges to the role, click **Add space privilege** in the Kibana section.

  4. One additional doc reference:

    . Add space privileges.

"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "これらの権限はすべての現在および未来のスペースに適用されます。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "グローバル権限の作成は他のスペース権限に影響を与える可能性があります。",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change. Our translation service will update these labels as needed.

Suggested change
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限",

"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "这些权限将应用到所有当前和未来工作区。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "创建全局权限可能会影响您的其他工作区权限。",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change. Our translation service will update these labels as needed.

Suggested change
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad! Should have used better grep expression searching for that! I'll try updating that tomorrow!

@legrego
Copy link
Member

legrego commented Nov 4, 2020

Closing, as this was resolved instead via #78152

@legrego legrego closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💝community release_note:enhancement Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change "Spaces privileges" to "Kibana privileges"

4 participants