-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Update 'space privileges' to 'kibana privileges' #74622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'space privileges' to 'kibana privileges' #74622
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Pinging @elastic/kibana-security (Team:Security) |
legrego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Miehau, thanks for taking the time to put this PR together, we really appreciate it!
In addition to the title change you made, I think it'd also be a good idea to update the button text as well. This actually manifests itself in a number of places:
-
Button text:
Lines 199 to 202 in bf04235
<FormattedMessage id="xpack.security.management.editRole.spacePrivilegeSection.addSpacePrivilegeButton" defaultMessage="Add space privilege" /> -
Corresponding test title:
Line 87 in b82cc6e
it('Renders flyout after clicking "Add space privilege" button', () => { -
A number of documentation references in this file should be renamed to reflect the updated button text (a quick find of "Add space privilege" in this file will assist):
To assign {kib} privileges to the role, click **Add space privilege** in the Kibana section. -
One additional doc reference:
. Add space privileges.
| "xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "これらの権限はすべての現在および未来のスペースに適用されます。", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "グローバル権限の作成は他のスペース権限に影響を与える可能性があります。", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this change. Our translation service will update these labels as needed.
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限", | |
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限", |
| "xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "这些权限将应用到所有当前和未来工作区。", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "创建全局权限可能会影响您的其他工作区权限。", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限", | ||
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this change. Our translation service will update these labels as needed.
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权", | |
| "xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad! Should have used better grep expression searching for that! I'll try updating that tomorrow!
|
Closing, as this was resolved instead via #78152 |
Summary
Updates naming from 'Space privileges' to 'Kibana privileges' for english, japanese and chinese languages.
Summon @legrego
Closes #74526
Checklist
Delete any items that are not applicable to this PR.
For maintainers