Grouped features for role management #78152

legrego · 2020-09-22T13:45:14Z

Groups features by category for Role Management

The role management screen has been updated to take advantage of the feature categories introduced in #74151. The old implementation displayed a flat table of features, and the ordering was not always predictable.

The updated interface organizes features according to the category in which they exist. Features can be configured independently as before. Unlike #74151, the categories for role management do not allow toggling privileges for entire categories. This was done to reduce confusion on an already complex form.

Out of scope

Additional design edits for role management are out-of-scope for this PR, and will be addressed in a followup as time permits.

Relates: #72659
Resolves #54794
Resolves #74526

legrego · 2020-09-25T19:31:27Z

...rity/public/management/roles/edit_role/privileges/kibana/feature_table/__fixtures__/index.ts

This fixture is responsible for parsing the rendered component tree to extract the displayed privileges.

As a result of the refactoring here, dependent tests were updated to always expect a subFeaturePrivileges array in the response, whereas before it was optionally defined.

legrego · 2020-09-25T20:09:44Z

x-pack/plugins/spaces/public/management/edit_space/section_panel/section_panel.tsx

Removing dead code now that the spaces panels cannot be collapsed. Technically unrelated to this PR 😬

elasticmachine · 2020-09-28T17:24:22Z

Pinging @elastic/kibana-security (Team:Security)

azasypkin · 2020-10-01T13:30:00Z

ACK: will review today

azasypkin

Looks great! Tested locally all the scenarios I could think of and everything worked as expected.

azasypkin · 2020-10-01T13:59:12Z

docs/user/security/authorization/index.asciidoc

 available; otherwise, it is not visible.

-To apply your changes, click **Create space privilege**. The space privilege shows up under the Kibana privileges section of the role.
+To apply your changes, click **Add Kibana privilege**. The space privilege shows up under the Kibana privileges section of the role.


question: any reason you use {kib} in some places and hardcoded Kibana in others in this file? Also we still reference to privileges as space privileges in this document in some places, are these just leftovers or we want to explicitly say that these are Kibana privileges that are specific to some spaces?

nope, just oversights! I will be overhauling these docs after FF, but I'll correct now and adjust after with fresh screenshots and the like

azasypkin · 2020-10-01T14:30:17Z

...ecurity/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table.scss

+  background-color: $euiColorLightestShade;
+  padding-left: $euiSizeXXL;
+  padding-top: $euiSizeS;
+}


nit: missing new line at the EOF?

Suggested change

}

}

azasypkin · 2020-10-01T14:55:57Z

...security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table.tsx


-        if (feature2.reserved && !feature1.reserved) {
-          return -1;
+      const label: string = i18n.translate(


optional nit: you could also use FormattedMessage react component. It's not a big deal, "theoretically" it's supposed to be more optimized for React, but I haven't seen any evidence yet, so up to you.

legrego · 2020-10-02T00:29:28Z

@elasticmachine merge upstream

kibanamachine · 2020-10-02T02:25:01Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 1d61e21
Flaky suites:
- xpack-kibana-ciGroup9

Test Failures

X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/execution_status·ts.alerting api integration spaces only Alerting executionStatus should eventually be "ok" for no-op alert

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: alerting api integration spaces only
[00:00:00]           │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1601598532327042654] [.kibana_1/-JE4UuVDR_WL7UkJ-MQdZA] update_mapping [_doc]
[00:00:00]           └-> "before all" hook
[00:00:39]           └-: Alerting
[00:00:39]             └-> "before all" hook
[00:00:39]             └-> "before all" hook
[00:00:39]               │ debg creating space
[00:00:39]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1601598532327042654] [.kibana_2/zFBqp_LbRBuuqMMDtKPcTg] update_mapping [_doc]
[00:00:40]               │ debg created space
[00:00:40]               │ debg creating space
[00:00:41]               │ debg created space
[00:02:17]             └-: executionStatus
[00:02:17]               └-> "before all" hook
[00:02:17]               └-> should be "pending" for newly created alert
[00:02:17]                 └-> "before each" hook: global before each
[00:02:19]                 └- ✓ pass  (1.9s) "alerting api integration spaces only Alerting executionStatus should be "pending" for newly created alert"
[00:02:19]               └-> should eventually be "ok" for no-op alert
[00:02:19]                 └-> "before each" hook: global before each
[00:02:21]                 │ proc [kibana]   log   [01:31:00.034] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-10-02T01:31:00.032Z","end":"2020-10-02T01:31:00.032Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"736e6131-1bfe-4877-a393-dd4a5ae2ab76","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:736e6131-1bfe-4877-a393-dd4a5ae2ab76: 'abc'","@timestamp":"2020-10-02T01:31:00.032Z","ecs":{"version":"1.5.0"}}
[00:02:21]                 │ proc [kibana]   log   [01:31:00.038] [info][eventLog][plugins] event logged: {"event":{"provider":"alerting","action":"execute","start":"2020-10-02T01:31:00.037Z","end":"2020-10-02T01:31:00.037Z","duration":0,"outcome":"success"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"b92e8b3b-747c-4a24-9fe5-9692176bb7de","namespace":"space1"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: test.noop:b92e8b3b-747c-4a24-9fe5-9692176bb7de: 'abc'","@timestamp":"2020-10-02T01:31:00.037Z","ecs":{"version":"1.5.0"}}
[00:02:21]                 └- ✖ fail: alerting api integration spaces only Alerting executionStatus should eventually be "ok" for no-op alert
[00:02:21]                 │       Error: expected [ '2020-10-02T01:30:58.118Z',
[00:02:21]                 │   '2020-10-02T01:30:58.126Z',
[00:02:21]                 │   '2020-10-02T01:31:00.125Z',
[00:02:21]                 │   '2020-10-02T01:31:00.038Z',
[00:02:21]                 │   '2020-10-02T01:31:00.136Z' ] to sort of equal [ '2020-10-02T01:30:58.118Z',
[00:02:21]                 │   '2020-10-02T01:30:58.126Z',
[00:02:21]                 │   '2020-10-02T01:31:00.038Z',
[00:02:21]                 │   '2020-10-02T01:31:00.125Z',
[00:02:21]                 │   '2020-10-02T01:31:00.136Z' ]
[00:02:21]                 │       + expected - actual
[00:02:21]                 │ 
[00:02:21]                 │        [
[00:02:21]                 │          "2020-10-02T01:30:58.118Z"
[00:02:21]                 │          "2020-10-02T01:30:58.126Z"
[00:02:21]                 │       +  "2020-10-02T01:31:00.038Z"
[00:02:21]                 │          "2020-10-02T01:31:00.125Z"
[00:02:21]                 │       -  "2020-10-02T01:31:00.038Z"
[00:02:21]                 │          "2020-10-02T01:31:00.136Z"
[00:02:21]                 │        ]
[00:02:21]                 │       
[00:02:21]                 │       at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
[00:02:21]                 │       at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
[00:02:21]                 │       at ensureDatetimesAreOrdered (test/alerting_api_integration/common/lib/test_assertions.ts:22:26)
[00:02:21]                 │       at Context.it (test/alerting_api_integration/spaces_only/tests/alerting/execution_status.ts:73:7)
[00:02:21]                 │ 
[00:02:21]                 │

Stack Trace

{ Error: expected [ '2020-10-02T01:30:58.118Z',
  '2020-10-02T01:30:58.126Z',
  '2020-10-02T01:31:00.125Z',
  '2020-10-02T01:31:00.038Z',
  '2020-10-02T01:31:00.136Z' ] to sort of equal [ '2020-10-02T01:30:58.118Z',
  '2020-10-02T01:30:58.126Z',
  '2020-10-02T01:31:00.038Z',
  '2020-10-02T01:31:00.125Z',
  '2020-10-02T01:31:00.136Z' ]
    at Assertion.assert (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/2/kibana/packages/kbn-expect/expect.js:244:8)
    at ensureDatetimesAreOrdered (test/alerting_api_integration/common/lib/test_assertions.ts:22:26)
    at Context.it (test/alerting_api_integration/spaces_only/tests/alerting/execution_status.ts:73:7)
  actual:
   '[\n  "2020-10-02T01:30:58.118Z"\n  "2020-10-02T01:30:58.126Z"\n  "2020-10-02T01:31:00.125Z"\n  "2020-10-02T01:31:00.038Z"\n  "2020-10-02T01:31:00.136Z"\n]',
  expected:
   '[\n  "2020-10-02T01:30:58.118Z"\n  "2020-10-02T01:30:58.126Z"\n  "2020-10-02T01:31:00.038Z"\n  "2020-10-02T01:31:00.125Z"\n  "2020-10-02T01:31:00.136Z"\n]',
  showDiff: true }

Metrics [docs]

async chunks size

id	before	after	diff
`security`	1.0MB	1.0MB	+1.6KB

page load bundle size

id	before	after	diff
`spaces`	346.9KB	345.5KB	-1.4KB

History

💚 Build #77261 succeeded 60d4f22
💚 Build #77229 succeeded 34365ee17fca0047fe57dbf7820e7ef2eb357c0b
💚 Build #76267 succeeded 3503921ea9d54245b7b9549afc2e99ffe5265692
💔 Build #76256 failed 878fe69d07adf5451ede268f7afe01e927bf30f3
💔 Build #76178 failed deb5de5a19ae52829ac2a17b4fb4cb21d690a0f0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Grouped features for role management * address PR feedback Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # docs/user/security/authorization/index.asciidoc

legrego force-pushed the fc/grouped-features-roles branch 3 times, most recently from 3503921 to 34365ee Compare September 25, 2020 20:08

Grouped features for role management

60d4f22

legrego force-pushed the fc/grouped-features-roles branch from 34365ee to 60d4f22 Compare September 27, 2020 17:28

legrego commented Sep 28, 2020

View reviewed changes

legrego marked this pull request as ready for review September 28, 2020 17:23

legrego requested a review from a team as a code owner September 28, 2020 17:23

legrego added :Security/Feature Controls release_note:enhancement Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.10.0 v8.0.0 labels Sep 28, 2020

kobelb mentioned this pull request Sep 29, 2020

[RFC][Search] Background sessions RFC #73281

Merged

azasypkin self-requested a review October 1, 2020 13:30

azasypkin approved these changes Oct 1, 2020

View reviewed changes

address PR feedback

3fac7da

Merge branch 'master' into fc/grouped-features-roles

1d61e21

legrego merged commit b9a7983 into elastic:master Oct 2, 2020

legrego deleted the fc/grouped-features-roles branch October 2, 2020 12:45

legrego mentioned this pull request Oct 2, 2020

[7.x] Grouped features for role management (#78152) #79282

Merged

legrego mentioned this pull request Nov 4, 2020

Update 'space privileges' to 'kibana privileges' #74622

Closed

3 tasks

Grouped features for role management #78152

Grouped features for role management #78152

Uh oh!

Conversation

legrego commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Groups features by category for Role Management

Out of scope

Uh oh!

legrego Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

legrego Sep 25, 2020

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 28, 2020

Uh oh!

azasypkin commented Oct 1, 2020

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

azasypkin Oct 1, 2020

Choose a reason for hiding this comment

Uh oh!

legrego Oct 2, 2020

Choose a reason for hiding this comment

Uh oh!

azasypkin Oct 1, 2020

Choose a reason for hiding this comment

Uh oh!

azasypkin Oct 1, 2020

Choose a reason for hiding this comment

Uh oh!

legrego commented Oct 2, 2020

Uh oh!

kibanamachine commented Oct 2, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

legrego commented Sep 22, 2020 •

edited

Loading