Skip to content

Update 'space privileges' to 'kibana privileges' #74622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update 'space privileges' to 'kibana privileges' #74622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deb00d2
Change name of form to 'Kibana privileges' from 'Space privileges'
Miehau Aug 9, 2020
de88ada
Add translations for Japanese and Chinese
Miehau Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class PrivilegeSpaceForm extends Component<Props, State> {
<h2>
<FormattedMessage
id="xpack.security.management.editRole.spacePrivilegeForm.modalTitle"
defaultMessage="Space privileges"
defaultMessage="Kibana privileges"
/>
</h2>
</EuiTitle>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14868,7 +14868,7 @@
"xpack.security.management.editRole.spacePrivilegeForm.featurePrivilegeSummaryDescription": "機能によってはスペースごとに非表示になっているか、グローバルスペース権限による影響を受けているものもあります。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "これらの権限はすべての現在および未来のスペースに適用されます。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "グローバル権限の作成は他のスペース権限に影響を与える可能性があります。",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限",
Copy link
Member

@legrego legrego Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change. Our translation service will update these labels as needed.

Suggested change
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 権限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "スペース権限",

"xpack.security.management.editRole.spacePrivilegeForm.privilegeSelectorFormLabel": "権限",
"xpack.security.management.editRole.spacePrivilegeForm.readPrivilegeDetails": "選択されたスペースの全機能への読み込み専用アクセスを許可します。",
"xpack.security.management.editRole.spacePrivilegeForm.readPrivilegeDisplay": "読み込み",
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14873,7 +14873,7 @@
"xpack.security.management.editRole.spacePrivilegeForm.featurePrivilegeSummaryDescription": "某些功能可能被工作区隐藏或受全局工作区权限影响。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeNotice": "这些权限将应用到所有当前和未来工作区。",
"xpack.security.management.editRole.spacePrivilegeForm.globalPrivilegeWarning": "创建全局权限可能会影响您的其他工作区权限。",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权",
Copy link
Member

@legrego legrego Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this change. Our translation service will update these labels as needed.

Suggested change
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "Kibana 特权",
"xpack.security.management.editRole.spacePrivilegeForm.modalTitle": "工作区权限,

Copy link
Author

@Miehau Miehau Aug 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad! Should have used better grep expression searching for that! I'll try updating that tomorrow!

"xpack.security.management.editRole.spacePrivilegeForm.privilegeSelectorFormLabel": "权限",
"xpack.security.management.editRole.spacePrivilegeForm.readPrivilegeDetails": "授予对选定工作区所有功能的只读访问权限。",
"xpack.security.management.editRole.spacePrivilegeForm.readPrivilegeDisplay": "读取",
Expand Down