Skip to content

Move kuery_autocomplete ⇒ NP #56607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 4, 2020
Merged

Move kuery_autocomplete ⇒ NP #56607

merged 10 commits into from
Feb 4, 2020

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 3, 2020 •
edited
Loading

Closes: #51277

Summary

  • Create new platform x-pack/plugins/data_xpack plugin
  • Move kuery_autocomplete to data_enhanced/public/autocomplete

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Feb 3, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 3, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes review labels Feb 3, 2020
@alexwizp alexwizp mentioned this pull request Feb 3, 2020
Merged
@alexwizp alexwizp marked this pull request as ready for review February 3, 2020 13:26
lizozom
lizozom approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM once green, but please consider naming issues.

@lukeelmers - lets get this decided!
@jasonrhodes - FYI

@Kerry350 Kerry350 mentioned this pull request Feb 3, 2020
Merged
lukeelmers
lukeelmers reviewed Feb 3, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM pending comments on Liza's review -- my only question is whether we should also be calling the directory data_enhanced instead of just data. Pretty much every other plugin has a directory name matching its plugin name/ID, so IMO developers would expect this to live in data_enhanced.

lizozom
lizozom reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one more comment about plugin naming, but overall LGTM

x-pack/plugins/data_enhanced/public/index.ts Outdated
*/
import { PluginInitializer } from 'kibana/public';
import {
DataEnhancedPublicPlugin as Plugin,
Copy link
Contributor

@lizozom lizozom Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add Public to everything anymore
DataEnhancedPlugin is the way to go.

FYI #55281 was merged, generating all the right shapes, for refernce.

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 4, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit be61507 into elastic:master Feb 4, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 4, 2020
@alexwizp
Move kuery_autocomplete ⇒ NP (elastic#56607)
c05de77 
* Move kuery_autocomplete ⇒ NP

Closes: elastic#51277

* fix i18n keys

* update translations

* data_xpack -> data_enhanced

* data -> data_enhanced

* fix i18nrc

* fix PR comments
@alexwizp alexwizp mentioned this pull request Feb 4, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 4, 2020
@gmmorris
Merge branch 'master' into alerting/get-alert-state
28e7c7e 
* master: (42 commits)
  Move kuery_autocomplete ⇒ NP (elastic#56607)
  [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595)
  [Discover] Inline angular directives only used in this plugin (elastic#56119)
  [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011)
  [SIEM] Enable flow_target_select_connected unit tests (elastic#55618)
  Start consuming np logging config (elastic#56480)
  [SIEM] Add eslint-plugin-react-perf (elastic#55960)
  Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613)
  Add `getServerInfo` API to http setup contract (elastic#56636)
  Updates Monitoring alert Jest snapshots
  Kibana property config migrations (elastic#55937)
  Vislib replacement toggle (elastic#56439)
  [Uptime] Add unit tests for QueryContext time calculation (elastic#56671)
  [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts
  Upgrade EUI to v18.3.0 (elastic#56228)
  [Maps] Fix server log (elastic#56679)
  [SIEM] Fixes FTUE when APM node is present (elastic#56574)
  [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563)
  Update EMS API urls for production (elastic#56657)
  Ability to delete alerts even when AAD is out of sync (elastic#56543)
  ...
alexwizp added a commit that referenced this pull request Feb 5, 2020
@alexwizp @elasticmachine
Move kuery_autocomplete ⇒ NP (#56607) (#56752)
433de85 
* Move kuery_autocomplete ⇒ NP

Closes: #51277

* fix i18n keys

* update translations

* data_xpack -> data_enhanced

* data -> data_enhanced

* fix i18nrc

* fix PR comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers left review comments

@ppisljar ppisljar Awaiting requested review from ppisljar

+1 more reviewer

@lizozom lizozom lizozom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexwizp alexwizp

Labels

Feature:KQL KQL Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move kuery_autocomplete ⇒ NP

5 participants

@alexwizp @elasticmachine @kibanamachine @lukeelmers @lizozom