[SIEM] Add eslint-plugin-react-perf #55960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
requested review from
FrankHassanabad,
XavierM,
andrew-goldstein,
angorayc,
cnasikas,
rylnd,
spong and
stephmilovic
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
angorayc
approved these changes
Feb 4, 2020
Contributor
angorayc
left a comment
angorayc
left a comment
There was a problem hiding this comment.
Cool stuff, I'll try to fix some problems it reported as well!
Contributor
Author
|
Thank you @angorayc 💪 |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
Feb 4, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2020
* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@XavierM did a great job with recognizing and fixing some of the performance issues in our app #55885
To continue his effort I've decided to install this plugin and see if it's going to be helpful.
It found at least 384 💥 places were we pass a new object/array/function as a prop that causes unnecessary re-renders in components.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers