[Maps] LayerControl read only mode #31318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
Author
|
This is a known issue that is getting addressed in EUI - elastic/eui#1571 and will go away with an EUI upgrade. The PR switches
|
Contributor
Author
|
To test, just manually edit and setisReadOnly mode to true
|
Contributor
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 20, 2019
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
nice. +1 on just managing this in the store as opposed to getting this setting from some static module function. it will keep it aligned with the other UI-state.
Contributor
💚 Build Succeeded |
Contributor
Author
|
7.x backport blocked by #31550 |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 20, 2019
* hide add layer button in read only mode * update TOCEntry for read only mode * make LayerTOC read only * default isReadOnly to false * remove action creator until its beig used
nreese
added a commit
that referenced
this pull request
Feb 20, 2019
|
@nreese if a role has read only access to a space, is this the mode that will now be presented to them? |
|
And if so, would it close this in your opinion? #30313 |
Contributor
Author
|
👍 sounds good, thanks @nreese |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
isReadOnlymode to the ui store. When true,LayerControldoes not displayAdd layerbuttonThe reason for large number of changes is this PR starts to add jest snapshot tests for the LayerControl to verify isReadOnly flag does the above actions.