[7.17] fixed undefined error when missing policy vars in template #124480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#121349) (elastic#121447) * [Reporting] Clarify deprecation changes of the roles settings * updates per feedback * update test snapshots * minor fix * fix i18n * remove formatting marks Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
…ldcard paths (elastic#120349) (elastic#121448) * Show full executable names in placeholder for wildcard paths fixes elastic/security-team/issues/2293 * Show soft warning when wildcard also in executable names fixes elastic/security-team/issues/2293 * add wildcard path entries to fake TA list refs elastic/security-team/issues/2293 * Append a process.name entry when executable name in wildcard path fixes elastic/security-team/issues/2293 * commit using ashokaditya@elastic.co * linux should always use `_cased` types review changes * use better TS * use matcher functions to compute operator value for linux review suggestions * use path to extract filenames on server side review suggestions * improve regex for windows and unix filepaths review suggestions * update test mocks review changes * update regex to match multi spaces and single chars with spaces in filenames * add comment to explain review suggestions * update copy Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/common/endpoint/data_generators/exceptions_list_item_generator.ts # x-pack/plugins/security_solution/public/management/pages/mocks/trusted_apps_http_mocks.ts # x-pack/plugins/security_solution/public/management/pages/policy/view/trusted_apps/layout/policy_trusted_apps_layout.test.tsx # x-pack/plugins/security_solution/public/management/pages/trusted_apps/view/trusted_apps_page.test.tsx
…tic#121215)" (elastic#121470) (elastic#121473) This reverts commit 3f321d1. Co-authored-by: Jonathan Budzenski <jon@elastic.co>
* added fleet setup before installing integration * added fleet setup error toast message * added try catch
…astic#121525) * Marking config as optional * Filtering out preconfigured connectors Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
…ic#121527) Co-authored-by: Renovate Bot <bot@renovateapp.com> # Conflicts: # package.json Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ic#121214) (elastic#121532) * [Metrics UI] Add migrations for saved object references (elastic#121214) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Re-add fields removed in newer version Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> Co-authored-by: Felix Stürmer <felix.stuermer@elastic.co>
… then is hidden (elastic#121488) (elastic#121555) * [XY] Fixes the broken chart when an agg is placed in another axis and then is hidden * Fix yAxes ticks * Fix test borkem due to the change of the implementation Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
…20273) OS packages manage Kibana's logging configuration and will be updated automatically to use the new logging configuration in 8.0. This skips the critical deprecation error that will be logged by the upgrade assistant for a package managed configuration. Related to elastic#111263 Related to elastic#109159 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…1328) (elastic#121570) The smoke tag is used in package testing to test kibana and associated binaries. Reporting spawns a chromium process, so it's a good candidate for package testing. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
* update task manager apm transactions * normalize reporting apm transaction names * update core transaction names * fix tests * typo + test * task manager types * consts * reporting transaction type * dummy * dummy * remove unused consts * Update src/core/server/server.ts Co-authored-by: Mikhail Shustov <restrry@gmail.com> * Update src/core/server/server.ts Co-authored-by: Mikhail Shustov <restrry@gmail.com> * Update src/core/server/server.ts Co-authored-by: Mikhail Shustov <restrry@gmail.com> * new line * Update x-pack/plugins/task_manager/server/task_running/ephemeral_task_runner.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * Update x-pack/plugins/task_manager/server/task_running/ephemeral_task_runner.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * alerting code review * ok Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mikhail Shustov <restrry@gmail.com> Co-authored-by: ymao1 <ying.mao@elastic.co> # Conflicts: # x-pack/plugins/reporting/common/constants.ts
…x) (elastic#121590) (elastic#121608) ## [Security Solution] Fixes issues with the Raw events Top N view (redux) This PR contains the same fixes described below from elastic#121562 , but doesn't depend on the following constants deleted from `@kbn/rule-data-utils` by elastic#121135 ``` ALERT_RULE_RISK_SCORE ALERT_RULE_RISK_SCORE_MAPPING ALERT_RULE_SEVERITY ALERT_RULE_SEVERITY_MAPPING ``` This PR fixes the following issues with the Raw events Top N view: - Fixes an issue <elastic#121168> where the Sourcerer context included detection alerts in the Raw events view, per the before screenshot below: ### Before  _Above: Before - the Raw events view includes detection alerts_ ### After  _Above: After - The Raw events view does NOT include detection alerts_ - Fixes an issue <elastic#121381> where when inspecting Raw events, `Sorry about that, something went wrong` is displayed when the Sourcerer context does not match the current selection: ### Before  _Above: Before - When users `Inspect` the Raw events view, `Sorry about that, something went wrong` is displayed_ ### After  _Above: After - When users `Inspect` the raw events view, the expected Index pattern reflects the current Sourcerer selection_ - Fixes an issue where the following filters in the `Security > Alerts` and `Security > Rule > Details` views: - `kibana.alert.building_block_type`: an "Additional filters" option on the alerts table - `kibana.alert.rule.rule_id`: filters alerts to a single rule on the `Security > Rules > Details` views - `kibana.alert.rule.name`: not a built-in view filter, but frequently applied via the `Filter In` and `Filter Out` actions - `kibana.alert.rule.threat_mapping`: an "Additional filters" option on the alerts table - `kibana.alert.workflow_status`: The `open | acknowledged | closed` status filter were incorrectly applied to the Raw events view, per the screenshots below: ### Before Inspecting the Raw events query reveals the alert filters are applied as filter criteria, per the screenshot below:  _Above: Before - The alert filters are applied to the Raw events view_ ### After After the fix, the alert filters are NOT applied to the raw events view, per the screenshot below:  _Above: After - The alert filters are NOT applied to the Raw events view_ # Conflicts: # x-pack/plugins/security_solution/public/common/components/top_n/top_n.tsx
…20230) (elastic#121591) Update dependency @elastic/charts to v40.2.0 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
…lastic#121635) Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
…#121647) This PR utilizes the functional test runner to walk through the UI and take a couple screenshots for use in the documentation. # Conflicts: # x-pack/test/functional/services/ml/test_resources.ts
…121649) * Fix savedObjectsTagging FTR test flakiness * set default value for refreshCache Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
…reated wrapper (elastic#121493) (elastic#121651) * Fix WebElementWrapper.findByTestSubject incorrectly passing a css selector to created wrapper * lint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
…astic#121666) * [Usage collection] Update bulkFetch logic (elastic#121437) * Update collector_set.ts Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
…c#121687) (elastic#121718) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…astic#114020) (elastic#121722) * Added close index test. * Fixed linting issues. * Fixed linting issues. * Abstracted out the index action option selection method and cleaned up test. * Merged Yulia's changes into this PR and updated the test to consume the new data test subjects. * Adjusted assertion to check for second to last request since there is a refresh done after the close index call. * Fixed linting issue. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…ettings (elastic#119144) (elastic#121724) * [Index Management] Improve error messages when editing index settings (elastic#119144) * Improve error message and start writting tests * Refactor tests * Fix tests * commit using @elastic.co * Refactor test * Add documentation * Fix ts types * Address CR changes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/test_subjects.ts # x-pack/plugins/index_management/public/application/sections/home/index_list/detail_panel/edit_settings_json/edit_settings_json.js * Fix import path
…initialized (elastic#120031) (elastic#121699) * [Uptime] Drop requests for overview page data when filter not initialized (elastic#120031) * Drop requests for overview page data when the value for the es filters has not been initially set. * Update to not wait when no filters are defined. * Add tests and clean up some files. * Delete unneeded code. * Reduce check condition to single boolean value to avoid triggering effect multiple times. * Simplify implementation, fix race. Update tests and fix types. * Make `useOverviewFilterCheck` consider kuery search as well. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/uptime/public/lib/helper/rtl_helpers.tsx * Fix linting error.
…lastic#123961) Testing against 8.0 requires system index write access introduced in elastic#123337. This adds a temporary skip while the backport is in progress.
…lastic#123980) (cherry picked from commit 159825a) Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
…ization tests (elastic#123899) (elastic#123931) This PR stabilizes the date nanos job and categorization job tests for cloud execution by reducing the job run time. (cherry picked from commit 4f1d97a) Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
…sponse (elastic#123939) This PR fixes the jobs_summary API tests for the `7.latest ES 8.1 forward compatibility` scenario by making it only check expected fields in the response body and ignore additional fields that are coming from the newer ES version.
* Fixes missing border in kql bar in Firefox * remove extra line
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 860a207) Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
… data view in analyzer (elastic#122859) (elastic#124002) * chore: add message about missing index in data view * fix: typo Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9f6c781) Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
(cherry picked from commit bc74ed2) Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
…astic#124158) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com>
…lastic#123285) (elastic#124177) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx # x-pack/plugins/infra/public/alerting/inventory/components/expression_chart.tsx # x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx # x-pack/plugins/infra/public/alerting/inventory/index.ts # x-pack/plugins/infra/public/alerting/metric_anomaly/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/components/expression_row.tsx # x-pack/plugins/infra/public/alerting/metric_threshold/index.ts # x-pack/plugins/infra/public/plugin.ts # x-pack/plugins/infra/server/features.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/evaluate_condition.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/lib/calculate_from_based_on_metric.ts # x-pack/plugins/infra/server/lib/alerting/metric_anomaly/metric_anomaly_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/metric_query.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/metrics_ui/inventory_threshold_alert.ts # x-pack/test/api_integration/apis/metrics_ui/metric_threshold_alert.ts
* Unskip search api tests (elastic#123145) (cherry picked from commit d84a5df) # Conflicts: # x-pack/test/api_integration/apis/search/search.ts * Fix backport Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
… URL (elastic#123386) (elastic#124217) * [maps] fix Unable to load layers from WMS spec for a specific URL * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d7bce1c) Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
…24233) * [Maps] drawing layer documentation (elastic#123373) * [Maps] drawing layer documentation * fix formatting * more formating fixes * text changes * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * review feedback * Update docs/maps/import-geospatial-data.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fix formatting of nested bullet Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b6a0a23) * replace data view with index pattern Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
…124042) (elastic#124055) (cherry picked from commit a7603dd) Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
… (elastic#123950) (cherry picked from commit 7dedc88) Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
(cherry picked from commit de9f1d4) Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
…c#121241) (elastic#124293) * [Dashboard][Embeddable] Create Explicit Diffing System (elastic#121241) Co-authored-by: Anton Dosov <dosantappdev@gmail.com> Co-authored-by: nreese <reese.nathan@elastic.co> (cherry picked from commit 944ccf1) # Conflicts: # src/plugins/dashboard/public/application/lib/diff_dashboard_state.ts # x-pack/plugins/maps/server/plugin.ts * type fix * replace ecommerce sample map id
…20815) (elastic#124295) * [Dashboard] Fix blank panel save and display issue. (elastic#120815) * Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. (cherry picked from commit b6013d1) # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx * replace lens basic with esarchiver * remove describe.only Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
(cherry picked from commit 291fa71) Co-authored-by: stuart nelson <stuartnelson3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport #124215 to 7.17