-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] fix Unable to load layers from WMS capabilities for a specific URL #123386
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
code review and tested in chrome.
Pinging @elastic/kibana-gis (Team:Geo) |
… URL (elastic#123386) * [maps] fix Unable to load layers from WMS spec for a specific URL * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d7bce1c)
… URL (elastic#123386) * [maps] fix Unable to load layers from WMS spec for a specific URL * eslint Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit d7bce1c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Fixes #122957
https://datacarto.datara.gouv.fr/wms capabilities returns results where
layer.Name
is not provided. The logic tried to read fromlayer.Name
and this return the error seen in the screen shot from the issue. The fix is to wrap reading with_.get
so an empty string is returned if the element does not exist.