Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] fix Unable to load layers from WMS capabilities for a specific URL #123386

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 19, 2022

Fixes #122957

https://datacarto.datara.gouv.fr/wms capabilities returns results where layer.Name is not provided. The logic tried to read from layer.Name and this return the error seen in the screen shot from the issue. The fix is to wrap reading with _.get so an empty string is returned if the element does not exist.

Screen Shot 2022-01-19 at 12 14 16 PM

@nreese nreese added release_note:fix v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v7.17.0 labels Jan 19, 2022
@nreese nreese requested a review from nickpeihl January 19, 2022 17:11
@nreese nreese requested a review from a team as a code owner January 19, 2022 17:11
@nreese
Copy link
Contributor Author

nreese commented Jan 28, 2022

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Jan 31, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] OSS Firefox Tests / console app console app should add comma after previous non empty line on autocomplete

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome.

@nreese nreese added v7.17.0 and removed v7.17.0 labels Feb 1, 2022
@nreese nreese merged commit d7bce1c into elastic:main Feb 1, 2022
@nreese nreese added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Feb 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 1, 2022
… URL (elastic#123386)

* [maps] fix Unable to load layers from WMS spec for a specific URL

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d7bce1c)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 1, 2022
… URL (elastic#123386)

* [maps] fix Unable to load layers from WMS spec for a specific URL

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d7bce1c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 1, 2022
… URL (#123386) (#124217)

* [maps] fix Unable to load layers from WMS spec for a specific URL

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d7bce1c)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
kibanamachine added a commit that referenced this pull request Feb 1, 2022
… URL (#123386) (#124216)

* [maps] fix Unable to load layers from WMS spec for a specific URL

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit d7bce1c)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
@nreese nreese added v7.17.1 and removed v7.17.0 labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.17.1 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps][WMS] Unable to load layers for a specific URL
5 participants