[Fleet] added fleet setup before installing integration #121379

juliaElastic · 2021-12-16T08:52:18Z

Summary

Fix #120358

Calling setup fleet first when clicking on integration install button.

if fleet setup hasn't been done yet, the setup takes some time, so showing disabled "Installing" button.
If fleet setup has been done already, the call returns quickly

Steps to verify:

Start Kibana and ES 7.16.0 without Fleet Server, do not go to Fleet app
Go directly to an Integration detail settings tab, such as http://localhost:5601/app/integrations/detail/nginx-1.2.3/settings
Click install button
Verify on Network tab that fleet setup is called, and during that time, cannot click Install button again.
After setup returns, install should be completing successfully

Repeat the above with another integration and verify that setup is called and returning quickly.

What is alarming though is that first time the setup call takes almost 2 mins, and I see a few errors in kibana logs as well:

server    log   [10:04:43.409] [warning][fleet][plugins] Failure to install package [elastic_agent]: [{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"}],"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"},"status":400}]
server    log   [10:04:43.410] [error][fleet][plugins] uninstalling elastic_agent-1.3.0 after error installing: [{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"}],"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"},"status":400}]
server    log   [10:04:43.413] [error][fleet][plugins] failed to uninstall or rollback package after installation error Error: elastic_agent is installed by default and cannot be removed
server    log   [10:05:24.737] [warning][fleet][plugins] Failed installing package [elastic_agent] due to error: [{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"}],"type":"illegal_argument_exception","reason":"component template [metrics-elastic_agent.osquerybeat@custom] already exists"},"status":400}]

The same errors come when I navigate to Fleet to trigger setup first (on 7.16 branch)

elasticmachine · 2021-12-16T08:53:49Z

Pinging @elastic/fleet (Team:Fleet)

nchaulet · 2021-12-16T14:02:02Z

@juliaElastic The error you get seems to happens some time locally I think due to a race condition. That PR fix it in 8.0 but we should probably backport it to 7.16.x too #120819

nchaulet · 2021-12-16T14:15:27Z

...eet/public/applications/integrations/sections/epm/screens/detail/settings/install_button.tsx

    toggleInstallModal();
+    await sendPostFleetSetup({ forceRecreate: false });


We may want to handle the error happening in sendPostFleetSetup we probably want to close the install modal and show the error in a toast notification as we do in other place what do you think?

good point! do you think the installPackage should continue if setup fails? to fall back to the existing logic

Sure we can just catch the error add a toast and try to install the package 👍

added error toast, though it shows up for a short time only by default

simulated error by throwing error on backend:

nchaulet · 2021-12-16T15:27:56Z

...eet/public/applications/integrations/sections/epm/screens/detail/settings/install_button.tsx

  const handleClickInstall = useCallback(async () => {
    setFleetSetupInProgress(true);
    toggleInstallModal();
-    await sendPostFleetSetup({ forceRecreate: false });
+    const res = await sendPostFleetSetup({ forceRecreate: false });


a little nitpick but I would put this in a try catch to avoid uncaught exception here.

try { const res = await sendPostFleetSetup({ forceRecreate: false }); if (res.error) { throw res.error; } } catch (e) { // show toast }

kibana-ci · 2021-12-16T18:50:52Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	626.2KB	626.8KB	+635.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	108.2KB	108.5KB	+277.0B

History

💔 Build #13670 failed e8d4d8a
💚 Build #13588 succeeded 0cd3411

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

juliaElastic · 2021-12-17T06:57:00Z

FYI moved the target branch to 7.17

joshdover · 2021-12-17T13:15:32Z

@juliaElastic in case we have another 7.16.x release, can we backport this there as well?

amolnater-qasource · 2021-12-20T11:01:54Z

Hi @joshdover & @juliaElastic
We have revalidated this on released 7.16.2 self-managed environment and we are successfully able to reproduce this issue.

Unable to install Nginx integration on fresh kibana setup, when user didn't navigate to fleet tab.

Build details:
Build: 46307
Commit: 9b678a1
Artifact Link: https://www.elastic.co/downloads/past-releases/elasticsearch-7-16-2

Screenshot:

Further, we have also validated the same on latest 8.0 self-managed environment and we have found it fixed there.

Successfully able to install Nginx integration on fresh kibana setup, when user didn't navigate to fleet tab.

Build details:
Build: 48805
Commit: 002f9fa
Artifact Link: https://snapshots.elastic.co/8.0.0-7b79b556/downloads/kibana/kibana-8.0.0-SNAPSHOT-windows-x86_64.zip

Screenshot:

Thanks

juliaElastic · 2022-01-10T08:41:09Z

@joshdover sorry I missed you comment earlier. I'll backport to 7.16 branch

juliaElastic · 2022-01-10T08:59:45Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.16	Command failed: git reset --hard && git clean -d --force && git fetch elastic 7.16 && git checkout -B backport/7.16/pr-121379 elastic/7.16 --no-track
fatal: not a git repository (or any of the parent directories): .git

|

To backport manually run: node scripts/backport --pr 121379.
For more info read the Backport documentation

juliaElastic · 2022-01-10T09:02:34Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.16	Command failed: git reset --hard && git clean -d --force && git fetch elastic 7.16 && git checkout -B backport/7.16/pr-121379 elastic/7.16 --no-track
fatal: not a git repository (or any of the parent directories): .git

|

To backport manually run: node scripts/backport --pr 121379.
For more info read the Backport documentation

* added fleet setup before installing integration * added fleet setup error toast message * added try catch

…22509) * added fleet setup before installing integration * added fleet setup error toast message * added try catch

added fleet setup before installing integration

0cd3411

juliaElastic self-assigned this Dec 16, 2021

juliaElastic added release_note:skip Skip the PR/issue when compiling release notes v7.17.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 16, 2021

juliaElastic requested a review from a team December 16, 2021 10:37

nchaulet reviewed Dec 16, 2021

View reviewed changes

added fleet setup error toast message

e8d4d8a

nchaulet reviewed Dec 16, 2021

View reviewed changes

added try catch

e94b4b6

nchaulet approved these changes Dec 16, 2021

View reviewed changes

juliaElastic changed the base branch from 7.16 to 7.17 December 17, 2021 06:56

juliaElastic merged commit 887a955 into elastic:7.17 Dec 17, 2021

juliaElastic deleted the fix-integrations-install branch December 17, 2021 07:13

juliaElastic added a commit to juliaElastic/kibana that referenced this pull request Jan 10, 2022

[Fleet] added fleet setup before installing integration (elastic#121379)

3500619

* added fleet setup before installing integration * added fleet setup error toast message * added try catch

juliaElastic mentioned this pull request Jan 10, 2022

[7.16] added fleet setup before installing integration (#121379) #122509

Merged

juliaElastic added a commit that referenced this pull request Jan 10, 2022

[Fleet] added fleet setup before installing integration (#121379) (#1…

7e10d94

…22509) * added fleet setup before installing integration * added fleet setup error toast message * added try catch

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] added fleet setup before installing integration #121379

[Fleet] added fleet setup before installing integration #121379

juliaElastic commented Dec 16, 2021 •

edited

Loading

elasticmachine commented Dec 16, 2021

nchaulet commented Dec 16, 2021

nchaulet Dec 16, 2021

juliaElastic Dec 16, 2021

nchaulet Dec 16, 2021

juliaElastic Dec 16, 2021

nchaulet Dec 16, 2021

kibana-ci commented Dec 16, 2021

juliaElastic commented Dec 17, 2021

joshdover commented Dec 17, 2021

amolnater-qasource commented Dec 20, 2021

juliaElastic commented Jan 10, 2022

juliaElastic commented Jan 10, 2022

juliaElastic commented Jan 10, 2022

		toggleInstallModal();
		await sendPostFleetSetup({ forceRecreate: false });

[Fleet] added fleet setup before installing integration #121379

[Fleet] added fleet setup before installing integration #121379

Conversation

juliaElastic commented Dec 16, 2021 • edited Loading

Summary

elasticmachine commented Dec 16, 2021

nchaulet commented Dec 16, 2021

nchaulet Dec 16, 2021

Choose a reason for hiding this comment

juliaElastic Dec 16, 2021

Choose a reason for hiding this comment

nchaulet Dec 16, 2021

Choose a reason for hiding this comment

juliaElastic Dec 16, 2021

Choose a reason for hiding this comment

nchaulet Dec 16, 2021

Choose a reason for hiding this comment

kibana-ci commented Dec 16, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

juliaElastic commented Dec 17, 2021

joshdover commented Dec 17, 2021

amolnater-qasource commented Dec 20, 2021

juliaElastic commented Jan 10, 2022

juliaElastic commented Jan 10, 2022

💔 Some backports could not be created

juliaElastic commented Jan 10, 2022

💔 Some backports could not be created

juliaElastic commented Dec 16, 2021 •

edited

Loading