Skip to content

[ML] Angular based pages no longer use $q as the default Promise #28189

Closed

Description

Kibana version: 6.6+

Elasticsearch version: 6.6+

Server OS version: N/A

Browser version: All

Browser OS version: All

Original install method (e.g. download page, yum, from source, etc.): N/A

Describe the bug:
For every angular based page in ML, we replace window.Promise with $q, this allows us to share Promise based util functions between angular and react code without needing to explicitly call $applyAsync when a resolving promise has to update the page.
This happens in a resolver, added to the routing stage of each page, and so happens before the page has fully loaded.

A recent change in core kibana undoes this change, reverting Promise back to a non-angular version after these resolvers have been run.
#25711

This causes angular based pages to not update correctly when actions are performed or data has been loaded via a Promise

Steps to reproduce:

  1. Open the Single Metric Job creation page
  2. Refresh the page (F5/cmd-R)
  3. Attempt to create a new job. The chart loading spinner doesn't disappear.

Expected behavior:
Page should work as expected

**Screenshots (if relevant):**N/A

**Errors in browser console (if relevant):**N/A

**Provide logs and/or server output (if relevant):**N/A

**Any additional context:**N/A

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    :mlblockerbugFixes for quality problems that affect the customer experiencev6.6.0

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions