Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing promise override function #28360

Merged
merged 1 commit into from
Jan 9, 2019
Merged

[ML] Removing promise override function #28360

merged 1 commit into from
Jan 9, 2019

Conversation

jgowdyelastic
Copy link
Member

Summary

Part of #28189. Removes the last traces of the initPromise function used to override the native Promise

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml v6.6.0 v6.7.0 labels Jan 9, 2019
@jgowdyelastic jgowdyelastic self-assigned this Jan 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, goodbye initPromise()!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

peteharverson
peteharverson approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit b443bd4 into elastic:master Jan 9, 2019
This was referenced Jan 9, 2019
Closed
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience :ml non-issue Indicates to automation that a pull request should not appear in the release notes v6.6.0 v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson