Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds $applyAsync calls to angular based new jobs pages #28325

Merged
merged 3 commits into from
Jan 9, 2019
Merged

[ML] Adds $applyAsync calls to angular based new jobs pages #28325

merged 3 commits into from
Jan 9, 2019

Conversation

jgowdyelastic
Copy link
Member

Summary

Part of #28189. adds $applyAsync calls to functions which update the $scope and are called after a promise has resolved.
Also removes our, now broken, initialisation of the native Promise via the initPromise function.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v6.6.0 v7.0.0-alpha2 v6.7.0 labels Jan 9, 2019
@jgowdyelastic jgowdyelastic self-assigned this Jan 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title Adding apply async to new jobs pages [ML] Adds $applyAsync calls to angular based new jobs pages Jan 9, 2019
walterra
walterra approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic mentioned this pull request Jan 9, 2019
Closed
4 tasks
@jgowdyelastic jgowdyelastic force-pushed the adding-apply-async-to-new-jobs-pages branch from 5215f53 to ec30757 Compare January 9, 2019 14:05
alvarezmelissa87
alvarezmelissa87 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

peteharverson
peteharverson approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 22877eb into elastic:master Jan 9, 2019
This was referenced Jan 9, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes v6.6.0 v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @walterra @alvarezmelissa87 @peteharverson