bump es version, remove default storageClassName #94
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
should be |
|
👍 trying to helm install on new AWS EKS cluster and getting the error persistentvolume-controller storageclass.storage.k8s.io "standard" not found |
elasticsearch/Chart.yaml
Outdated
| @@ -4,8 +4,8 @@ maintainers: | |||
| - email: helm-charts@elastic.co | |||
| name: Elastic | |||
| name: elasticsearch | |||
| version: 6.6.2-alpha1 | |||
There was a problem hiding this comment.
Can you remove this version bump please. All versions of the charts are bumped and released at the same time (just like with all of the elastic stack). I went into more details in this PR if you are interested in the reasons why: #40 (comment)
There was a problem hiding this comment.
reverted chart version bump
| @@ -71,7 +71,6 @@ networkHost: "0.0.0.0" | |||
|
|
|||
| volumeClaimTemplate: | |||
| accessModes: [ "ReadWriteOnce" ] | |||
| storageClassName: "standard" | |||
There was a problem hiding this comment.
Awesome! This is much better. Can you also update the defaults in the readme to match https://github.com/elastic/helm-charts/tree/master/elasticsearch#configuration
|
jenkins test this please |
elasticsearch/Chart.yaml
Outdated
| @@ -5,7 +5,7 @@ maintainers: | |||
| name: Elastic | |||
| name: elasticsearch | |||
| version: 6.6.2-alpha1 | |||
| appVersion: 6.6.2 | |||
| appVersion: 6.7.1 | |||
There was a problem hiding this comment.
Something went wrong with the revert as the version bump is still here.
elasticsearch/README.md
Outdated
| @@ -55,14 +55,14 @@ If you currently have a cluster deployed with the [helm/charts stable](https://g | |||
| | `extraInitContainers` | Additional init containers to be passed to the `tpl` function | | | |||
| | `secretMounts` | Allows you easily mount a secret as a file inside the statefulset. Useful for mounting certificates and other secrets. See [values.yaml](./values.yaml) for an example | `{}` | | |||
| | `image` | The Elasticsearch docker image | `docker.elastic.co/elasticsearch/elasticsearch` | | |||
| | `imageTag` | The Elasticsearch docker image tag | `6.6.2` | | |||
| | `imageTag` | The Elasticsearch docker image tag | `6.7.1` | | |||
There was a problem hiding this comment.
This one should be reverted too.
elasticsearch/values.yaml
Outdated
| @@ -43,7 +43,7 @@ secretMounts: [] | |||
| # path: /usr/share/elasticsearch/config/certs | |||
|
|
|||
| image: "docker.elastic.co/elasticsearch/elasticsearch" | |||
| imageTag: "6.6.2" | |||
| imageTag: "6.7.1" | |||
This test will install the latest chart release and then attempt to upgrade to what is currently in git. This is designed to test two things. 1. That any changes do not happen to the statefulset that isn't allowed by Kubernetes. An example of this happening is #94 where the change was not caught as part of pull request testing but was luckily caught during manual testing before the release. 2. That a rolling upgrade actually works and results in a healthy cluster at the end. The test will always override the "terminationGracePeriod" to make sure that a rolling upgrade is always done even if there are no changes. Kubectl and helm have also been updated to the latest releases. Oddly enough there was a breaking change in the mock value used for release names where it is now lowercased for some reason. The kubectl upgraded was needed to get the handy timeout flag for the `kubectl rollout status`command to make sure that jobs don't hang forever if something does actually go wrong. This command is needed because the `helm --wait` flag only works `apps/v1` resources. See helm/helm#3173 for more information.
This pr
6.7.1standardstorageClassName by default as this value will be default storage class if empty(you don't need to specify this). In aws environment, default storage class is generallygp2, sovolumeClaimTemplateshould be always overridden.