Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

bump es version, remove default storageClassName #94

Merged
merged 7 commits into from
Apr 17, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove standard storageClassName in default values
  • Loading branch information
kimxogus committed Apr 12, 2019
commit 944687ce17c011413a3384d4ba04c00a0097e9ff
1 change: 0 additions & 1 deletion elasticsearch/tests/elasticsearch_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ def test_defaults():
assert v['metadata']['name'] == uname
assert v['spec']['accessModes'] == ['ReadWriteOnce']
assert v['spec']['resources']['requests']['storage'] == '30Gi'
assert v['spec']['storageClassName'] == 'standard'

# Init container
i = r['statefulset'][uname]['spec']['template']['spec']['initContainers'][0]
Expand Down
1 change: 0 additions & 1 deletion elasticsearch/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ networkHost: "0.0.0.0"

volumeClaimTemplate:
accessModes: [ "ReadWriteOnce" ]
storageClassName: "standard"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is much better. Can you also update the defaults in the readme to match https://github.com/elastic/helm-charts/tree/master/elasticsearch#configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated readme

resources:
requests:
storage: 30Gi
Expand Down