This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add resources to InitContainers #40
Merged
Crazybus
merged 4 commits into
elastic:master
from
powerhome:add-resources-for-initContainers
Jan 25, 2019
Merged
Add resources to InitContainers #40
Crazybus
merged 4 commits into
elastic:master
from
powerhome:add-resources-for-initContainers
Jan 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current init containers don't have resource limits specified so it you are deploying this into a cluster that has a ResourceQuota specified the deploy will fail.
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Crazybus
suggested changes
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the docs and testing changes I suggested.
I'm also making a note to create a contributing guide since I'll probably be repeating these comments on every single PR otherwise.
Document the usage of the initResources variable for setting resources for initContainers
This is updated when new release is pushed out.
Crazybus
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jenkins test this please |
Hooray! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current init containers don't have resource limits specified so it you are deploying this into a cluster that has a ResourceQuota specified the deploy will fail.