Backport packaging fixes #6525
Merged
Backport packaging fixes #6525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another attempt to fix the transient packaging error. I pushed the tudorg/xgo-base image to Docker Hub and have the build script pull it from there, rather than building it locally. This should reduce the amount of network dependencies and speed up the build as well. Same could be done for xgo-base-deb, but this part is currently more critical.
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
debian 6 has reached EOL and no longer has a valid package signing key, making apt-get installs unsafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple cherry-picks for packaging in 6.1.