Remove dependency on gopkg.in #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
graphaelli
approved these changes
Feb 23, 2018
|
|
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 23, 2018
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 23, 2018
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
graphaelli
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Use the tudorg/xgo-base image from docker hub (#6448) Another attempt to fix the transient packaging error. I pushed the tudorg/xgo-base image to Docker Hub and have the build script pull it from there, rather than building it locally. This should reduce the amount of network dependencies and speed up the build as well. Same could be done for xgo-base-deb, but this part is currently more critical. * Avoid git cloning from the deb6 image (#6459) It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally. * Remove dependency on gopkg.in (#6461) This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
ruflin
pushed a commit
that referenced
this pull request
Feb 27, 2018
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Mar 11, 2018
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
ruflin
pushed a commit
that referenced
this pull request
Mar 12, 2018
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Mar 14, 2018
This partially reverts elastic#6461 in the 5.6 branch. It looks like the release-manager uses a reasonably new Golang in the master/6.x branch but still uses go1.6 in the 5.6 branch. That causes problems when using the vendor folder, so i reverted to the old `go get`. It's more susceptible to transient errors, but that was stable for quite long. Also added `--force-yes` on the debian6 apt-gets, to avoid the key error. I didn't investigate if the backport of the deb7 change would be possible. If yes, that would be preferable, but I leave to @andrewkroh.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Use the tudorg/xgo-base image from docker hub (elastic#6448) Another attempt to fix the transient packaging error. I pushed the tudorg/xgo-base image to Docker Hub and have the build script pull it from there, rather than building it locally. This should reduce the amount of network dependencies and speed up the build as well. Same could be done for xgo-base-deb, but this part is currently more critical. * Avoid git cloning from the deb6 image (elastic#6459) It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally. * Remove dependency on gopkg.in (elastic#6461) This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the remaining
go getfor gotpl, by using the vendoredcopy. This should get rid of our dependency on the gopkg.in service.