Avoid git cloning from the deb6 image #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The longer term plan is to reconsider if we still need support for Debian 6. |
|
Can we use zips from https://github.com/go-yaml/yaml/archive/v2.zip and https://github.com/tsg/gotpl/archive/master.zip instead of adding them to the repo? |
andrewkroh
reviewed
Feb 23, 2018
| RUN git clone https://github.com/go-yaml/yaml.git /go/src/gopkg.in/yaml.v2 | ||
| # Old git version which does not support proxy with go get directly, and git cloning | ||
| # from github also no longer works. | ||
| ADD go-yaml.tar.gz /go-yaml.tar.gz |
There was a problem hiding this comment.
I think we would have move visibility into this dependency if it were copied from the dev-tools/vendor directory. This will probably be better for maintainability.
|
|
andrewkroh
approved these changes
Feb 23, 2018
| @@ -1,5 +1,6 @@ | |||
| #!/bin/sh | |||
|
|
|||
| cp -r ../../../vendor/gopkg.in/yaml.v2 beats-builder/yaml.v2 | |||
There was a problem hiding this comment.
Probably should add these dirs to .gitignore.
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
tsg
force-pushed
the
avoid_clone_on_deb6
branch
from
c9e7ed6 to
2bc4645
Compare
|
Added |
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 23, 2018
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
tsg
added a commit
to tsg/beats
that referenced
this pull request
Feb 23, 2018
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
graphaelli
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Use the tudorg/xgo-base image from docker hub (#6448) Another attempt to fix the transient packaging error. I pushed the tudorg/xgo-base image to Docker Hub and have the build script pull it from there, rather than building it locally. This should reduce the amount of network dependencies and speed up the build as well. Same could be done for xgo-base-deb, but this part is currently more critical. * Avoid git cloning from the deb6 image (#6459) It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally. * Remove dependency on gopkg.in (#6461) This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
ruflin
pushed a commit
that referenced
this pull request
Feb 27, 2018
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Mar 11, 2018
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
ruflin
pushed a commit
that referenced
this pull request
Mar 12, 2018
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* Use the tudorg/xgo-base image from docker hub (elastic#6448) Another attempt to fix the transient packaging error. I pushed the tudorg/xgo-base image to Docker Hub and have the build script pull it from there, rather than building it locally. This should reduce the amount of network dependencies and speed up the build as well. Same could be done for xgo-base-deb, but this part is currently more critical. * Avoid git cloning from the deb6 image (elastic#6459) It seems that by now Debian 6 is so old that `git clone` from Github repositories no longer works. We only needed git clone from it to get gotpl running, which is a relatively small program so I included it and its dependency (go-yaml) as vendored files. Tested `make package` locally. * Remove dependency on gopkg.in (elastic#6461) This removes the remaining `go get` for gotpl, by using the vendored copy. This should get rid of our dependency on the gopkg.in service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that by now Debian 6 is so old that
git clonefrom Githubrepositories no longer works. We only needed git clone from it to
get gotpl running, which is a relatively small program so I included it
and its dependency (go-yaml) as a zip file.
Tested
make packagelocally.