Agent configuration integration tests #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and adapt them for kibana being available by default
graphaelli
commented
Jul 12, 2019
graphaelli
commented
Jul 12, 2019
| "acm_cache_expiration": "1ms", # no cache | ||
| } | ||
|
|
||
| def create_service_config(self, settings, name, env=None, _id="new"): |
There was a problem hiding this comment.
This function has me thinking about a subcommand for apm-server that manipulates agent configs
simitt
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
This is great, thanks so much for doing this @graphaelli !
Let's merge this in and I'll rebase my PRs onto it and get the remaining tests fixed.
| config_overrides = { | ||
| "logging_json": "true", | ||
| "kibana_enabled": "true", | ||
| "acm_cache_expiration": "1ms", # no cache |
There was a problem hiding this comment.
sidenote: This won't work with #2443. But let's first merge in this PR and worry about that later.
1 task
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jul 12, 2019
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Jul 12, 2019
simitt
pushed a commit
that referenced
this pull request
Jul 12, 2019
simitt
pushed a commit
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts kibana for integration tests now, alongside previously started elasticsearch.
Includes (commented out) failing tests/todos for #2434 and #2438.
closes #2219