-
Notifications
You must be signed in to change notification settings - Fork 532
[ACM] Only allow cache expiration values in full seconds. #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, even makes test confg
fail if the value is bad. If we need this validation elsewhere we should pull it into a ucfg validator eg
apm-server/beater/config_helper.go
Line 30 in aa13cef
if err := ucfg.RegisterValidator("maxlen", func(v interface{}, param string) error { |
Per discussion, we can update the integration test introduced in #2439 to check this. |
I generally agree regarding the |
* [ACM] Only allow cache expiration values in full seconds. fixes elastic#2438
* [ACM] Only allow cache expiration values in full seconds. fixes elastic#2438
fixes #2438
backport to
7.x
and7.3
.