Skip to content

[ACM] Only allow cache expiration values in full seconds. #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2019

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jul 12, 2019

fixes #2438

  • changelog entry

backport to 7.x and 7.3.

Copy link
Member

@graphaelli graphaelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, even makes test confg fail if the value is bad. If we need this validation elsewhere we should pull it into a ucfg validator eg

if err := ucfg.RegisterValidator("maxlen", func(v interface{}, param string) error {

@graphaelli
Copy link
Member

Per discussion, we can update the integration test introduced in #2439 to check this.

@simitt
Copy link
Contributor Author

simitt commented Jul 12, 2019

I generally agree regarding the Unpack but we also use the same Cache struct for the sourcemapping cache and wouldn't want to introduce limitation there just now (might be a breaking change).

@simitt simitt merged commit a958d40 into elastic:master Jul 12, 2019
simitt added a commit to simitt/apm-server that referenced this pull request Jul 12, 2019
* [ACM] Only allow cache expiration values in full seconds.

fixes elastic#2438
simitt added a commit to simitt/apm-server that referenced this pull request Jul 12, 2019
* [ACM] Only allow cache expiration values in full seconds.

fixes elastic#2438
graphaelli pushed a commit that referenced this pull request Jul 12, 2019
)

* [ACM] Only allow cache expiration values in full seconds.

fixes #2438
graphaelli pushed a commit that referenced this pull request Jul 12, 2019
)

* [ACM] Only allow cache expiration values in full seconds.

fixes #2438
@simitt simitt deleted the 2438-cache-config branch July 23, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Central config: non-integer cache-control headers
2 participants