Update src/jquery.multiselect.filter.js #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed error menu is undefined error on line 32. Changed .data('multiselect'); to .data('echMultiselect');
Added var _self = this; on line 62 of the toggleChecked override function so that the options in the original select get modified when checks get toggled.
Owner
|
you're the man. what's the |
Owner
There was a problem hiding this comment.
Can you change these few lines to something like:
var elem = $(this.element);
var instance = (this.instance = (elem.data("echMultiselect") || elem.data("multiselect")));So that we can maintain 1.8 compatibility? Then I'll merge. Thanks!
Contributor
Author
There was a problem hiding this comment.
No problem. This doesn't actually make it backwards compatible. I tested this with 1.9.0 jQuery along with jQuery UI 1.10.0(newest stuff) and jQuery 1.5.0 along with jQuery UI 1.8.7.
ehynds
pushed a commit
that referenced
this pull request
Feb 7, 2013
Update src/jquery.multiselect.filter.js
This was referenced Feb 7, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error menu is undefined error on line 32. Changed .data('multiselect'); to .data('echMultiselect');
Added var _self = this; on line 62 of the toggleChecked override function so that the options in the original select get modified when checks get toggled.