Skip to content

Update src/jquery.multiselect.filter.js #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2013
Merged

Update src/jquery.multiselect.filter.js #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/jquery.multiselect.filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
var opts = this.options;

// get the multiselect instance
var instance = (this.instance = $(this.element).data('multiselect'));
var instance = (this.instance = $(this.element).data('echMultiselect'));
Copy link
Owner

@ehynds ehynds Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change these few lines to something like:

var elem = $(this.element);
var instance = (this.instance = (elem.data("echMultiselect") || elem.data("multiselect")));

So that we can maintain 1.8 compatibility? Then I'll merge. Thanks!

Copy link
Contributor Author

@davidworkman9 davidworkman9 Feb 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. This doesn't actually make it backwards compatible. I tested this with 1.9.0 jQuery along with jQuery UI 1.10.0(newest stuff) and jQuery 1.5.0 along with jQuery UI 1.8.7.


// store header; add filter class so the close/check all/uncheck all links can be positioned correctly
var header = (this.header = instance.menu.find('.ui-multiselect-header').addClass('ui-multiselect-hasfilter'));
Expand Down Expand Up @@ -59,6 +59,7 @@
// only the currently filtered elements are checked
instance._toggleChecked = function(flag, group) {
var $inputs = (group && group.length) ? group : this.labels.find('input');
var _self = this;

// do not include hidden elems if the menu isn't open.
var selector = instance._isOpen ? ':disabled, :hidden' : ':disabled';
Expand Down