Remove getRegisterSaveDescription from metadata #7334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
reviewed
Oct 3, 2019
| @@ -1469,8 +1465,6 @@ createMethodMetaData( | |||
| sizeOfStackAtlasInBytes, | |||
| nonmergeableBCI); | |||
|
|
|||
| data->registerSaveDescription = comp->cg()->getRegisterSaveDescription(); | |||
|
|
|||
There was a problem hiding this comment.
This is still needed. This is a different "registerSaveDescription" that's used to describe registers preserved in the prologue.
There was a problem hiding this comment.
This may very well be the cause of your CI failures.
Signed-off-by: Aidan Ha <qbha@edu.uwaterloo.ca>
Signed-off-by: Aidan Ha <qbha@edu.uwaterloo.ca>
|
You'll need to rebase to pick up the |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #7256 we can remove the registerSaveDescription class member, as this is the only consumer of the RSD from the Instruction class, which is not set anywhere and is slated for removal in #7203.
Downstream relative to eclipse-omr/omr#4379