Add an entry to support newvalue into CodeGenGPU #6569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change supports the newvalue opcode. Issue: eclipse-openj9#4028 Signed-off-by: Yiling Han <Yiling.Han@ibm.com>
|
This must depend on an OMR change? If so can you please identify which one? |
|
Could you also please make the PR title and message a bit more meaningful so that one doesn't have to read the commit? |
|
The change depends on eclipse-omr/omr#4156. |
Charlmzz
changed the title
andrewcraik
added
comp:jit
depends:omr
|
Updated for review. |
|
This is a simple add and the sanity won't work with the OMR now out of whack so I'm going to merge this now to get an acceptance build going. I have checked the change it is a single line addition at the correct point in the opcode table to make the opcodes in OpenJ9 line up with OMR once again. |
andrewcraik
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry to support newvalue into CodeGenGPU.
Issue: #4028
Signed-off-by: Yiling Han Yiling.Han@ibm.com