Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _registerSaveDescription field from Instruction class #7203

Closed
0xdaryl opened this issue Sep 24, 2019 · 2 comments · Fixed by #7265
Closed

Remove _registerSaveDescription field from Instruction class #7203

0xdaryl opened this issue Sep 24, 2019 · 2 comments · Fixed by #7265
Labels
comp:jit

Comments

@0xdaryl
Copy link
Contributor

0xdaryl commented Sep 24, 2019

The _registerSaveDescription field in J9Instruction.hpp is no longer used, and neither are its getters and setters. Remove them.

There is an identical field in the parent OMRInstruction.hpp that is also no longer used (see issue eclipse-omr/omr#4350). Between these two issues, we can save 16 bytes per Instruction.
@0xdaryl
Copy link
Contributor Author

0xdaryl commented Sep 24, 2019

@AidanHa , would you mind handling this please?

@AidanHa
Copy link
Contributor

AidanHa commented Sep 24, 2019 •
edited
Loading

Sure, I have some PRs' in works at the moment, but I can get this one done.

@0xdaryl 0xdaryl mentioned this issue Sep 26, 2019
Open
@AidanHa AidanHa mentioned this issue Sep 27, 2019
Merged
AidanHa added a commit to AidanHa/openj9 that referenced this issue Sep 27, 2019
@AidanHa
Remove _registerSaveDescription field in J9Instruction.hpp
85708ae 
Remove field, which is no longer in use
Remove getters and setters for this field

Fixes eclipse-openj9#7203

Signed-off-by: Aidan Ha <qbha@edu.uwaterloo.ca>
This was referenced Sep 30, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove _registerSaveDescription field in J9Instruction.hpp AidanHa/openj9
2 participants
@0xdaryl @AidanHa