-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove indexed maps that are not used along the code #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two general comments:
- If we are removing the collections, shouldn't we just remove the corresponding tests instead of modifying them?
- Linters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI. We'll leave the tests there till we check whether we have other tests checking the same things indirectly.
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
82b8375
to
9694f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3dfa570
to
f267a35
Compare
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
f267a35
to
736d776
Compare
Codecov ReportBase: 0.00% // Head: 57.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
=========================================
+ Coverage 0 57.82% +57.82%
=========================================
Files 0 31 +31
Lines 0 4320 +4320
Branches 0 2310 +2310
=========================================
+ Hits 0 2498 +2498
- Misses 0 60 +60
- Partials 0 1762 +1762
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merge after: