Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flaky test labels and update CI so flakys are run in another job #175

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add flaky test labels and update CI so flakys are run in another job #175

merged 1 commit into from
Oct 18, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 13, 2022 •
edited
Loading

No description provided.

Add flaky test labels and update CI so flakys are run in another job
d780176 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov October 13, 2022 07:37 Inactive
This was referenced Oct 17, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Draft
MiguelCompany
MiguelCompany requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new flaky-test job runs only on ubuntu-latest, this means that the tests marked as xfail will never be run on windows.

I think we should add a flaky-test-windows job

@jparisu
Copy link
Contributor Author

jparisu commented Oct 17, 2022

The new flaky-test job runs only on ubuntu-latest, this means that the tests marked as xfail will never be run on windows.

I think we should add a flaky-test-windows job

These tests have been running and failing on windows and nobody cared.
I think knowing that they keep failing on windows will not give any new information.
Mark them as xfail is to remind us that they should be fixed, not to check their output when they fail (that is always, and that has been checked never).

@MiguelCompany MiguelCompany merged commit 4676eb2 into main Oct 18, 2022
@MiguelCompany MiguelCompany deleted the ci/xfail branch October 18, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparisu @MiguelCompany