Duck.ai: Omnibar interactions #7074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
0b7b286 to
a76d661
Compare
malmstein
force-pushed
the
feature/david/11-06-duck.ai_omnibar_interactions
branch
from
22ef7ab to
f125341
Compare
malmstein
force-pushed
the
feature/david/11-06-duck.ai_omnibar_interactions
branch
3 times, most recently
from
d29475e to
a380796
Compare
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
6402858 to
cf1afcc
Compare
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
cf1afcc to
194e53a
Compare
malmstein
force-pushed
the
feature/david/11-06-duck.ai_omnibar_interactions
branch
from
a380796 to
137ee1f
Compare
joshliebe
reviewed
Nov 7, 2025
| val hasPendingDuckAiOpen = externalIntentProcessingState.hasPendingDuckAiOpen.value | ||
| if (!hasPendingTabLaunch && !hasPendingDuckAiOpen) { | ||
| // whenever an event fires, so the user switched to a new tab page, launch the input screen | ||
| command.value = LaunchInputScreen |
malmstein
merged commit 81873cb
into
feature/david/10-24-duck.ai_omnibar
5 of 6 checks passed
malmstein
deleted the
feature/david/11-06-duck.ai_omnibar_interactions
branch
malmstein
added a commit
that referenced
this pull request
Nov 7, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211877638725902?focus=true ### Description This PR adds CTA for the main actions in the Duck.ai Omnibar ### Steps to test this PR _Feature Flag enabled_ - [x] Ensure Fullscreen mode is enabled in AI Features - [x] Open Duck.ai - [x] Verify new Omnibar is visible - [x] Tap on the Fire Button - [x] Verify the Bottom Sheet appears (Tab restoration is not implemented, so you’ll see NTP upon restart) - [x] Tap on Tab Switcher - [x] Verify Tab Manager appears (Duck.ai won’t be shown as a tab, not implemented yet) - [x] Tap on the input field - [x] Verify Input Screen appears - [x] Enter a search query - [x] Verify that the browser replaces Duck.ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211877638725902?focus=true
Description
This PR adds CTA for the main actions in the Duck.ai Omnibar
Steps to test this PR
Feature Flag enabled