added missing tests for the shared viewModel

Author: malmstein

duckchat/duckchat-api/build.gradle

@@ -36,6 +36,21 @@ dependencies {
     implementation AndroidX.appCompat
 
     coreLibraryDesugaring Android.tools.desugarJdkLibs
+
+    testImplementation Testing.junit4
+    testImplementation "org.mockito.kotlin:mockito-kotlin:_"
+    testImplementation project(path: ':common-test')
+    testImplementation "androidx.test.ext:junit-ktx:_"
+    testImplementation project(':feature-toggles-test')
+    testImplementation CashApp.turbine
+    testImplementation Testing.robolectric
+    testImplementation(KotlinX.coroutines.test) {
+        // https://github.com/Kotlin/kotlinx.coroutines/issues/2023
+        // conflicts with mockito due to direct inclusion of byte buddy
+        exclude group: "org.jetbrains.kotlinx", module: "kotlinx-coroutines-debug"
+    }
+    testImplementation AndroidX.lifecycle.runtime.testing
+    testImplementation AndroidX.archCore.testing
 }
 
 

duckchat/duckchat-api/src/main/java/com/duckduckgo/duckchat/api/viewmodel/DuckChatSharedViewModel.kt

@@ -33,7 +33,7 @@ class DuckChatSharedViewModel() : ViewModel() {
         }
     }
 
-    fun onTabSwitcherCLicked() {
+    fun onTabSwitcherClicked() {
         viewModelScope.launch {
             _command.send(Command.LaunchTabSwitcher)
         }

duckchat/duckchat-api/src/test/kotlin/com/duckduckgo/duckchat/api/viewmodel/DuckChatSharedViewModelTest.kt

@@ -0,0 +1,83 @@
+/*
+ * Copyright (c) 2025 DuckDuckGo
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.duckduckgo.duckchat.api.viewmodel
+
+import androidx.arch.core.executor.testing.InstantTaskExecutorRule
+import app.cash.turbine.test
+import com.duckduckgo.common.test.CoroutineTestRule
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.test.runTest
+import org.junit.Assert.assertEquals
+import org.junit.Before
+import org.junit.Rule
+import org.junit.Test
+
+@OptIn(ExperimentalCoroutinesApi::class)
+class DuckChatSharedViewModelTest {
+
+    @get:Rule
+    val coroutineRule = CoroutineTestRule()
+
+    @get:Rule
+    @Suppress("unused")
+    var instantTaskExecutorRule = InstantTaskExecutorRule()
+
+    private lateinit var testee: DuckChatSharedViewModel
+
+    @Before
+    fun before() {
+        testee = DuckChatSharedViewModel()
+    }
+
+    @Test
+    fun `when onFireButtonClicked then emit LaunchFire Command`() =
+        runTest {
+            testee.onFireButtonClicked()
+            testee.command.test {
+                assertEquals(DuckChatSharedViewModel.Command.LaunchFire, awaitItem())
+            }
+        }
+
+    @Test
+    fun `when onTabSwitcherCLicked then emit LaunchTabSwitcher Command`() =
+        runTest {
+            testee.onTabSwitcherClicked()
+            testee.command.test {
+                assertEquals(DuckChatSharedViewModel.Command.LaunchTabSwitcher, awaitItem())
+            }
+        }
+
+    @Test
+    fun `when onSearchRequested then emit SearchRequested Command`() =
+        runTest {
+            val query = "example.com"
+            testee.onSearchRequested(query)
+            testee.command.test {
+                assertEquals(DuckChatSharedViewModel.Command.SearchRequested(query), awaitItem())
+            }
+        }
+
+    @Test
+    fun `when openExistingTab then emit OpenTab Command`() =
+        runTest {
+            val tabId = "tabId"
+            testee.openExistingTab(tabId)
+            testee.command.test {
+                assertEquals(DuckChatSharedViewModel.Command.OpenTab(tabId), awaitItem())
+            }
+        }
+}

duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewFragment.kt

@@ -118,7 +118,7 @@ open class DuckChatWebViewFragment : DuckDuckGoFragment(R.layout.activity_duck_c
         ViewModelProvider(this, viewModelFactory)[DuckChatWebViewViewModel::class.java]
     }
 
-    private val sharedViewModel: DuckChatSharedViewModel by activityViewModels()
+    private val browseSharedViewModel: DuckChatSharedViewModel by activityViewModels()
 
     @Inject
     lateinit var webViewClient: DuckChatWebViewClient
@@ -386,11 +386,11 @@ open class DuckChatWebViewFragment : DuckDuckGoFragment(R.layout.activity_duck_c
         duckChatOmnibar?.setOmnibarItemPressedListener(
             object : DuckChatOmnibarLayout.ItemPressedListener {
                 override fun onTabsButtonPressed() {
-                    sharedViewModel.onTabSwitcherCLicked()
+                    browseSharedViewModel.onTabSwitcherClicked()
                 }
 
                 override fun onFireButtonPressed() {
-                    sharedViewModel.onFireButtonClicked()
+                    browseSharedViewModel.onFireButtonClicked()
                 }
 
                 override fun onBrowserMenuPressed() {
@@ -439,25 +439,25 @@ open class DuckChatWebViewFragment : DuckDuckGoFragment(R.layout.activity_duck_c
             when (result.resultCode) {
                 InputScreenActivityResultCodes.NEW_SEARCH_REQUESTED -> {
                     data?.getStringExtra(InputScreenActivityResultParams.SEARCH_QUERY_PARAM)?.let { query ->
-                        sharedViewModel.onSearchRequested(query)
+                        browseSharedViewModel.onSearchRequested(query)
                     }
                 }
 
                 InputScreenActivityResultCodes.SWITCH_TO_TAB_REQUESTED -> {
                     data?.getStringExtra(InputScreenActivityResultParams.TAB_ID_PARAM)?.let { tabId ->
-                        sharedViewModel.openExistingTab(tabId)
+                        browseSharedViewModel.openExistingTab(tabId)
                     }
                 }
 
                 InputScreenActivityResultCodes.MENU_REQUESTED -> {
                 }
 
                 InputScreenActivityResultCodes.TAB_SWITCHER_REQUESTED -> {
-                    sharedViewModel.onTabSwitcherCLicked()
+                    browseSharedViewModel.onTabSwitcherClicked()
                 }
 
                 InputScreenActivityResultCodes.FIRE_BUTTON_REQUESTED -> {
-                    sharedViewModel.onFireButtonClicked()
+                    browseSharedViewModel.onFireButtonClicked()
                 }
             }
         }