Duck.ai: Omnibar #7065
Merged
Duck.ai: Omnibar #7065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
fa387bc to
ff64ca4
Compare
11 tasks
joshliebe
reviewed
Nov 7, 2025
duckchat/duckchat-impl/src/main/res/values/attrs-omnibar-view.xml
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 7, 2025
joshliebe
reviewed
Nov 7, 2025
joshliebe
reviewed
Nov 7, 2025
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
0b7b286 to
a76d661
Compare
joshliebe
reviewed
Nov 7, 2025
joshliebe
reviewed
Nov 7, 2025
duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewFragment.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 7, 2025
duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewFragment.kt
Outdated
Show resolved
Hide resolved
joshliebe
reviewed
Nov 7, 2025
...chat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/ui/DuckChatWebViewViewModel.kt
Outdated
Show resolved
Hide resolved
joshliebe
approved these changes
Nov 7, 2025
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
Clicking on the DuckChatOmnibar when the Input Screen is disabled opens the tab selector or overflow menu (depending on where you click), just so you know.
Otherwise LGTM.
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
2 times, most recently
from
cf1afcc to
194e53a
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/1174433894299346/task/1211877638725902?focus=true ### Description This PR adds CTA for the main actions in the Duck.ai Omnibar ### Steps to test this PR _Feature Flag enabled_ - [x] Ensure Fullscreen mode is enabled in AI Features - [x] Open Duck.ai - [x] Verify new Omnibar is visible - [x] Tap on the Fire Button - [x] Verify the Bottom Sheet appears (Tab restoration is not implemented, so you’ll see NTP upon restart) - [x] Tap on Tab Switcher - [x] Verify Tab Manager appears (Duck.ai won’t be shown as a tab, not implemented yet) - [x] Tap on the input field - [x] Verify Input Screen appears - [x] Enter a search query - [x] Verify that the browser replaces Duck.ai
malmstein
force-pushed
the
feature/david/10-24-duck.ai_omnibar
branch
from
81873cb to
01a5f93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1211821284193228
Description
This PR adds the new Duck.ai omnibar behind a feature flag
Steps to test this PR
Legacy Mode
Fullscreen Mode
UI changes