Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve xml comments review 5th DRAFT #12148

Draft
wants to merge 839 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 15, 2024

Addresses improved XML comment in #11984

Proposed changes

  • Add and improve XML comments in VB code

Customer Impact

  • Improve WinForms Design experience

Regression?

  • No

Risk

  • None - no code changes
Microsoft Reviewers: Open in CodeFlow

@paul1956 paul1956 requested a review from a team as a code owner September 15, 2024 23:33
@paul1956 paul1956 changed the title Improve xml comments review 6th draft Improve xml comments review 6th DRAFT Sep 15, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 89.05788% with 259 lines in your changes missing coverage. Please review.

Project coverage is 75.79714%. Comparing base (fae358b) to head (1cc2260).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12148         +/-   ##
===================================================
+ Coverage   75.69021%   75.79714%   +0.10693%     
===================================================
  Files           3151        3156          +5     
  Lines         635600      637656       +2056     
  Branches       46951       47044         +93     
===================================================
+ Hits          481087      483325       +2238     
+ Misses        151076      150885        -191     
- Partials        3437        3446          +9     
Flag Coverage Δ
Debug 75.79714% <89.05788%> (+0.10693%) ⬆️
integration 18.15260% <8.28471%> (-0.09497%) ⬇️
production 49.39215% <70.34884%> (+0.16749%) ⬆️
test 97.06125% <99.73457%> (+0.01072%) ⬆️
unit 46.46433% <63.02326%> (+0.26915%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the draft draft PR label Sep 18, 2024
@Tanya-Solyanik Tanya-Solyanik marked this pull request as draft September 18, 2024 01:50
@paul1956 paul1956 changed the title Improve xml comments review 6th DRAFT Improve xml comments review 5th DRAFT Sep 19, 2024
paul1956 and others added 30 commits November 6, 2024 23:28
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
[main] Update dependencies from dotnet/arcade
* Add code coverage for TrackBarRenderer

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks
[main] Update dependencies from dotnet/arcade
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes.

See a discussion on this here: dotnet/runtime#44194
…' into Shorten-long-inline-comments-Review-4th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants