Remove CLSCompliant attribute #12469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes. See a discussion on this here: dotnet/runtime#44194
| <Import Project="$(RepositoryEngineeringDir)Test.targets" Condition="'$(IsTestProject)' == 'true' "/> | ||
|
|
||
| <PropertyGroup> | ||
| <Description Condition="'$(Description)' == ''">$(AssemblyName)</Description> |
src/System.Windows.Forms/src/System/Windows/Forms/OLE/DataObject.DataStore.cs
Show resolved
Hide resolved
Tanya-Solyanik
approved these changes
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12469 +/- ##
===================================================
- Coverage 75.71861% 75.71609% -0.00253%
===================================================
Files 3152 3152
Lines 635709 635709
Branches 46970 46970
===================================================
- Hits 481350 481334 -16
- Misses 150916 150937 +21
+ Partials 3443 3438 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
paul1956
pushed a commit
to paul1956/winforms
that referenced
this pull request
Nov 13, 2024
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes. See a discussion on this here: dotnet/runtime#44194
JeremyKuhne
added a commit
to JeremyKuhne/winforms
that referenced
this pull request
Nov 14, 2024
This reverts commit f7a5332. Didn't realize the impact this would have upstream if dependencies were building as CLSCompliant.
JeremyKuhne
added a commit
that referenced
this pull request
Nov 14, 2024
Revert "Remove CLSCompliant attribute (#12469)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes.
See a discussion on this here: dotnet/runtime#44194
Microsoft Reviewers: Open in CodeFlow