Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Current VB work (Refactoring and adding tests) #12230

Open
3 tasks
KlausLoeffelmann opened this issue Sep 26, 2024 · 3 comments
Open
3 tasks

[Tracking] Current VB work (Refactoring and adding tests) #12230

KlausLoeffelmann opened this issue Sep 26, 2024 · 3 comments
Assignees
Milestone

Comments

@KlausLoeffelmann
Copy link
Member

KlausLoeffelmann commented Sep 26, 2024

[Draft]

This will be the tracking issues for all the ongoing VB work that we want to accomplish in the .NET 10-time frame.

@KlausLoeffelmann KlausLoeffelmann added this to the .NET 10.0 milestone Sep 26, 2024
@KlausLoeffelmann KlausLoeffelmann self-assigned this Sep 26, 2024
@KlausLoeffelmann KlausLoeffelmann changed the title [Tracking] Current VB word (Refactoring and adding tests) [Tracking] Current VB work (Refactoring and adding tests) Sep 26, 2024
@KlausLoeffelmann
Copy link
Member Author

@paul1956:

Could you please list your suggested PR order as I started it in an answer to this comment?
I will then take a look as soon as I get to it and paste it into this tracking issue.
Let's then tackle this step by step.

Please do not create another PR, before we have this sorted out! 😸

@paul1956
Copy link
Contributor

paul1956 commented Sep 26, 2024

The first 5 PR’s build on each other I learned not to do that after it was done. The critical issue is to fix #9807, followed by adding tests to the VB runtime. Everything else is general cleanup

#11863 Add tests for VB runtime REVIEW 1ST
Includes the first 3 PR’s below and many more tests, plus a download servers for testing, and some style fixes from reviews (it should be closed and the remaining changes put into small PR’s like at bottom.

#12227 Add Clipboard Proxy Tests from PR #11863
#12226 Split Network.VB into 7 Files from #11863
#12221 Extract only Network Download tests from #11863

#11867 Fix issue #9807 Replaces #9867 REVIEW (2nd) AFTER #11863 DRAFT
Changes 6 files from #11863 but includes all the code to replace WebClient for Download, optionally expose Async Download, upload is possible but I have no approved way to test. This also includes resources that will need translating they are private to WebClient.

#12118 Shorten long lines in VB REVIEW (3rd) AFTER fix issue#9807 DRAFT
Purely cleanup no logic changes. This shortens line over 120-130 characters in VB

#12139 Shorten long inline comments REVIEW (4th) DRAFT (purely cleanup no logic changes)
Purely C# cleanup no logic changes

#12148 Improve xml comments review 5th DRAFT

All the PR’s below are standalone and small based on Main.

#12141 Add XML Comments related to FileSystemProxy and SpecialDirectoriesProxy
Adds missing XML comments for VB Public functions.

#12139 shortens comments over 120-130 characters in C#
Purely C# cleanup no logic changes

#12148 improves XML comment by adding see cref’s (in C# and VB)
Purely cleanup no logic changes

@paul1956
Copy link
Contributor

This is the complete list of tests and test utilities that I think need to be added to the VB Code, some have already been merged.

The ones in red have already been merged. The TestData Directory gets added to over time as new tests are added.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants