Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten long inline comments REVIEW (4th) DRAFT #12139

Draft
wants to merge 785 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 14, 2024

Shorten long inline comments

Proposed changes

  • Wrap and in some cases move up a line, long inline comments.

Customer Impact

  • None

Regression?

  • No

Risk

  • None - no code changes
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 89.15254% with 256 lines in your changes missing coverage. Please review.

Project coverage is 75.79294%. Comparing base (fae358b) to head (7eb439f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12139         +/-   ##
===================================================
+ Coverage   75.69021%   75.79294%   +0.10273%     
===================================================
  Files           3151        3156          +5     
  Lines         635600      637657       +2057     
  Branches       46951       47044         +93     
===================================================
+ Hits          481087      483299       +2212     
+ Misses        151076      150924        -152     
+ Partials        3437        3434          -3     
Flag Coverage Δ
Debug 75.79294% <89.15254%> (+0.10273%) ⬆️
integration 18.14901% <8.35294%> (-0.09856%) ⬇️
production 49.38318% <70.45721%> (+0.15852%) ⬆️
test 97.06097% <99.73457%> (+0.01044%) ⬆️
unit 46.45784% <63.07151%> (+0.26266%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added the draft draft PR label Sep 14, 2024
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Sep 15, 2024
@paul1956 paul1956 changed the title Shorten long inline comments DRAFT Shorten long inline comments REVIEW (5th) DRAFT Sep 16, 2024
@paul1956 paul1956 changed the title Shorten long inline comments REVIEW (5th) DRAFT Shorten long inline comments REVIEW (4th) DRAFT Sep 19, 2024
@paul1956
Copy link
Contributor Author

@Tanya-Solyanik could you set this one to draft please.

@Tanya-Solyanik Tanya-Solyanik added the draft draft PR label Sep 21, 2024
@Tanya-Solyanik Tanya-Solyanik marked this pull request as draft September 21, 2024 15:30
Fix formatting
Move TestVbHost to separate file
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
paul1956 and others added 30 commits November 5, 2024 11:34
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
…' into Shorten-long-inline-comments-Review-4th
[main] Update dependencies from dotnet/arcade
* Add code coverage for TrackBarRenderer

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks

* Handle FeedBacks
[main] Update dependencies from dotnet/arcade
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes.

See a discussion on this here: dotnet/runtime#44194
…' into Shorten-long-inline-comments-Review-4th
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants