-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten long inline comments REVIEW (4th) DRAFT #12139
Draft
paul1956
wants to merge
785
commits into
dotnet:main
Choose a base branch
from
paul1956:Shorten-long-inline-comments
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,505
−1,170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12139 +/- ##
===================================================
+ Coverage 75.69021% 75.79294% +0.10273%
===================================================
Files 3151 3156 +5
Lines 635600 637657 +2057
Branches 46951 47044 +93
===================================================
+ Hits 481087 483299 +2212
+ Misses 151076 150924 -152
+ Partials 3437 3434 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
paul1956
changed the title
Shorten long inline comments DRAFT
Shorten long inline comments REVIEW (5th) DRAFT
Sep 16, 2024
paul1956
changed the title
Shorten long inline comments REVIEW (5th) DRAFT
Shorten long inline comments REVIEW (4th) DRAFT
Sep 19, 2024
@Tanya-Solyanik could you set this one to draft please. |
Fix formatting Move TestVbHost to separate file
Fix formatting
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
This was referenced Sep 26, 2024
…' into Shorten-long-inline-comments-Review-4th
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…-after-FixIssue#9807-3rd
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
[main] Update dependencies from dotnet/arcade
* Add code coverage for TrackBarRenderer * Handle FeedBacks * Handle FeedBacks * Handle FeedBacks * Handle FeedBacks
[main] Update dependencies from dotnet/arcade
It doesn't really matter anymore and is creating extra maintenance cost as we add new APIs. Remove versioning.targets as it did very little and all over the override attributes. See a discussion on this here: dotnet/runtime#44194
…-after-FixIssue#9807-3rd
…' into Shorten-long-inline-comments-Review-4th
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorten long inline comments
Proposed changes
Customer Impact
Regression?
Risk
Microsoft Reviewers: Open in CodeFlow