Skip to content

Update Microsoft.AspNetCore.Watch.BrowserRefresh to net8.0 #47509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 14, 2025
Merged

Update Microsoft.AspNetCore.Watch.BrowserRefresh to net8.0 #47509

merged 7 commits into from
Mar 14, 2025

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 12, 2025

net8.0 is now the oldest supported TFM

Copilot AI review requested due to automatic review settings March 12, 2025 15:58
@wtgodbe wtgodbe requested a review from a team as a code owner March 12, 2025 15:58
Copilot AI reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Mar 12, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 12, 2025

Thanks for your PR, @wtgodbe.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

ViktorHofer
ViktorHofer approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSimons this should allow the removal of the 6.0.2 targeting packs in SBRP.

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 12, 2025 •
edited
Loading

Looks like this will require some code changes to react to the TFM update - @captainsafia could you take a look?

Edit: Disregard, change was trivial

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 12, 2025

@ViktorHofer 2 new prebuilts:

/__w/1/vmr/repo-projects/Directory.Build.targets(924,5): warning : 2 new packages used not in baseline! See report at /__w/1/vmr/artifacts/prebuilt-report/baseline-comparison.xml for more information. Package IDs are: [/__w/1/vmr/repo-projects/dotnet.proj]
/__w/1/vmr/repo-projects/Directory.Build.targets(924,5): warning : Microsoft.AspNetCore.App.Ref.8.0.12 [/__w/1/vmr/repo-projects/dotnet.proj]
/__w/1/vmr/repo-projects/Directory.Build.targets(924,5): warning : Microsoft.NETCore.App.Ref.8.0.12 [/__w/1/vmr/repo-projects/dotnet.proj]

Do we need to bring back the SourceBuild bits? That version will always be the latest 8.0 unless we pin

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 13, 2025

Maybe we need to bring back 8.0.0 & pin to it: dotnet/source-build-reference-packages#1178

@wtgodbe wtgodbe mentioned this pull request Mar 13, 2025
Merged
@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 13, 2025

dotnet/source-build-reference-packages#1197

@wtgodbe
Copy link
Member Author

wtgodbe commented Mar 13, 2025

Next SBRP update should unblock

wtgodbe and others added 2 commits March 13, 2025 09:19
@wtgodbe
Add FrameworkReference for Microsoft.AspNetCore.App
655c237
@dotnet-maestro @wtgodbe
Update dependencies from https://github.com/dotnet/source-build-refer…
46f4225 
…ence-packages build 20250313.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.616001 -> To Version 10.0.616304
@wtgodbe wtgodbe mentioned this pull request Mar 13, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 14, 2025
Open
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 14, 2025 •
edited
Loading

CSC(0,0): error CS0006: (NETCORE_ENGINEERING_TELEMETRY=Build) Metadata file '/__w/1/vmr/src/sdk/artifacts/sb/package-cache/microsoft.aspnetcore.app.ref/8.0.0/analyzers/dotnet/cs/Microsoft.AspNetCore.App.Analyzers.dll' could not be found

Looks like the aspnetcore targeting pack incorrectly lists analyzers? cc @dotnet/source-build

Submitted dotnet/source-build-reference-packages#1199

@ViktorHofer ViktorHofer mentioned this pull request Mar 14, 2025
Merged
@ViktorHofer ViktorHofer mentioned this pull request Mar 14, 2025
Closed
@ViktorHofer ViktorHofer enabled auto-merge (squash) March 14, 2025 18:29
@build-analysis build-analysis bot mentioned this pull request Mar 14, 2025
Open
@ViktorHofer ViktorHofer merged commit 7842ae3 into main Mar 14, 2025
39 checks passed
@ViktorHofer ViktorHofer deleted the wtgodbe/BrowNet8 branch March 14, 2025 23:17
@tmat tmat mentioned this pull request Aug 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

No one assigned

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @ViktorHofer