Skip to content

Update Microsoft.AspNetCore.Watch.BrowserRefresh to net8.0 #47509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 14, 2025
Merged

Update Microsoft.AspNetCore.Watch.BrowserRefresh to net8.0 #47509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbc2f62
Update Microsoft.AspNetCore.Watch.BrowserRefresh to net8.0
wtgodbe Mar 12, 2025
088b6c8
Update target framework to net8.0
wtgodbe Mar 12, 2025
35f162b
Update BrowserRefreshMiddleware.cs
wtgodbe Mar 12, 2025
f1911fd
Add .NET 8.0.0 targeting pack reference
wtgodbe Mar 13, 2025
655c237
Add FrameworkReference for Microsoft.AspNetCore.App
wtgodbe Mar 13, 2025
46f4225
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 13, 2025
0fcb5cc
Update dependency version in Version.Details.xml
ViktorHofer Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,9 @@
<SourceBuild RepoName="source-build-externals" ManagedOnly="true" />
</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="10.0.616001">
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="10.0.616401">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>8f9f6fa14523b2f2475ea0a86be1cf60b5de5336</Sha>
<Sha>c3d4c372a15c2de79a2f26fe2b6b3644996d8550</Sha>
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Deployment.DotNet.Releases" Version="2.0.0-preview.1.25124.1">
Expand Down
4 changes: 2 additions & 2 deletions src/BuiltInTools/BrowserRefresh/BrowserRefreshMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ private void AttachWebAssemblyHeaders(HttpContext context)
{
if (_dotnetModifiableAssemblies != null)
{
context.Response.Headers.Add("DOTNET-MODIFIABLE-ASSEMBLIES", _dotnetModifiableAssemblies);
context.Response.Headers.Append("DOTNET-MODIFIABLE-ASSEMBLIES", _dotnetModifiableAssemblies);
}
else
{
Expand All @@ -98,7 +98,7 @@ private void AttachWebAssemblyHeaders(HttpContext context)
{
if (_aspnetcoreBrowserTools != null)
{
context.Response.Headers.Add("ASPNETCORE-BROWSER-TOOLS", _aspnetcoreBrowserTools);
context.Response.Headers.Append("ASPNETCORE-BROWSER-TOOLS", _aspnetcoreBrowserTools);
}
else
{
Expand Down
13 changes: 7 additions & 6 deletions src/BuiltInTools/BrowserRefresh/Microsoft.AspNetCore.Watch.BrowserRefresh.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- Intentionally pinned. This feature is supported in projects targeting 6.0 or newer.-->
<TargetFramework>net6.0</TargetFramework>
<!-- Intentionally pinned. This feature is supported in projects targeting 8.0 or newer.-->
<!-- This should always use the oldest supported TFM -->
<TargetFramework>net8.0</TargetFramework>
<StrongNameKeyId>MicrosoftAspNetCore</StrongNameKeyId>

<IsPackable>false</IsPackable>
Expand All @@ -16,9 +17,9 @@
</ItemGroup>

<ItemGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">
<!-- Reference 6.0.2 targeting packs in Source Build - this was the earliest version after the API surface stabilized -->
<FrameworkReference Update="Microsoft.AspNetCore.App" TargetingPackVersion="6.0.2" />
<FrameworkReference Update="Microsoft.NETCore.App" TargetingPackVersion="6.0.2" />
<!-- Reference 8.0.0 targeting packs in Source Build -->
<FrameworkReference Update="Microsoft.AspNetCore.App" TargetingPackVersion="8.0.0" />
<FrameworkReference Update="Microsoft.NETCore.App" TargetingPackVersion="8.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading