Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 13, 2025

Should unblock dotnet/sdk#47509

@wtgodbe wtgodbe changed the title Remove 6.0.2 Aspnetcore ref pack, add back 8.0.0 Remove 6.0.2 ref packs, add back 8.0.0 Mar 13, 2025
@MichaelSimons
Copy link
Member

FYI, I removed the KnownFrameworkReference handling for 6.0.2

@MichaelSimons MichaelSimons enabled auto-merge (squash) March 13, 2025 15:45
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a KnownFrameworkReference into src/referencePackages/Directory.Build.targets for aspnetcore (in case a package gets added here that depends on it):

<KnownFrameworkReference Update="@(KnownFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App'))">
      <TargetingPackVersion Condition="$([System.Text.RegularExpressions.Regex]::IsMatch('%(TargetFramework)', '^net\d+\.0$'))">$([System.Text.RegularExpressions.Regex]::Match('%(TargetFramework)', '\d+').Value).0.0</TargetingPackVersion>
    </KnownFrameworkReference>

@MichaelSimons MichaelSimons merged commit cac4d02 into dotnet:main Mar 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants