Skip to content

Conversation

@danmoseley
Copy link
Member

Fix #30108. remove the test: I cannot see how this test could pass. when you create a directory/file, it does not have default values for its various time attributes.
Fix #24295. We do not plan to make the enumerator thread safe. It happens to be thread safe on Windows, so leaving the test for Windows so that if we do change this for some reason, we can document it in case anyone depends on it.
Fix #43166. Per discussion, this cannot be made to work on modern Linux distros.

@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #30108. remove the test: I cannot see how this test could pass. when you create a directory/file, it does not have default values for its various time attributes.
Fix #24295. We do not plan to make the enumerator thread safe. It happens to be thread safe on Windows, so leaving the test for Windows so that if we do change this for some reason, we can document it in case anyone depends on it.
Fix #43166. Per discussion, this cannot be made to work on modern Linux distros.

Author: danmoseley
Assignees: -
Labels:

area-System.IO

Milestone: -

@danmoseley
Copy link
Member Author

I was looking through the ActiveIssues on System.IO.FileSystem to get an idea of how much cruft is there. Of 59 ActiveIssue attributes, there are only 12 distinct issues, of which 6 are device/blazor specific and thus relatively new, and of the remaining 6 I looked at 4 and clearly at least these 3 should not exist. They have all been present for years -- one of these issues is over 4 years old. This suggests there's a lot of cruft.

cc @stephentoub @eerhardt as both have pointed out we are over due for cleanup.

@danmoseley
Copy link
Member Author

Here's a snippet of one of the issues -- we should Be Bold in such cases:
image

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@danmoseley
Copy link
Member Author

@stephentoub

@danmoseley danmoseley merged commit 12b0ddb into dotnet:main Oct 1, 2021
@danmoseley danmoseley deleted the remove.active branch October 1, 2021 15:41
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

3 participants