Skip to content

Commit 12b0ddb

Browse files
Remove 3 active issues (#59790)
* Remove 3 active issues * Apply suggestions from code review Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
1 parent 5cd1454 commit 12b0ddb

File tree

3 files changed

+6
-19
lines changed

3 files changed

+6
-19
lines changed

src/libraries/System.IO.FileSystem/tests/Base/InfoGetSetTimes.cs

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,6 @@ public abstract class InfoGetSetTimes<T> : BaseGetSetTimes<T> where T : FileSyst
1111
{
1212
protected abstract void InvokeCreate(T item);
1313

14-
[Fact]
15-
[ActiveIssue("https://github.com/dotnet/runtime/issues/30108")]
16-
public void DoesntExistThenCreate_ReturnsDefaultValues()
17-
{
18-
T item = GetMissingItem();
19-
InvokeCreate(item);
20-
21-
Assert.All(TimeFunctions(), (function) =>
22-
{
23-
Assert.Equal(
24-
function.Kind == DateTimeKind.Local
25-
? DateTime.FromFileTime(0).Ticks
26-
: DateTime.FromFileTimeUtc(0).Ticks,
27-
function.Getter(item).Ticks);
28-
});
29-
}
30-
3114
[Fact]
3215
public void ExistsThenDelete_ReturnsDefaultValues()
3316
{

src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ namespace System.IO.Tests
1111
public class EnumerableTests : FileSystemTest
1212
{
1313
[Fact]
14-
[ActiveIssue("https://github.com/dotnet/runtime/issues/24295", TestPlatforms.AnyUnix)]
14+
// we don't guarantee thread safety of enumerators in general, but on Windows we
15+
// currently are thread safe, and this test will help ensure that if we change that
16+
// it's a conscious decision. Discussed in https://github.com/dotnet/runtime/issues/24295.
17+
[PlatformSpecific(TestPlatforms.Windows)]
1518
public void FileEnumeratorIsThreadSafe()
1619
{
1720
string directory = Directory.CreateDirectory(GetTestFilePath()).FullName;

src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,8 @@ public void SetUptoNanoseconds()
148148
Assert.Equal(ticks, dateTime.Ticks);
149149
}
150150

151-
[ActiveIssue("https://github.com/dotnet/runtime/issues/43166", TestPlatforms.Linux)]
151+
// Linux kernels no longer have long max date time support. Discussed in https://github.com/dotnet/runtime/issues/43166.
152+
[PlatformSpecific(~TestPlatforms.Linux)]
152153
[ConditionalFact(nameof(SupportsLongMaxDateTime))]
153154
public void SetDateTimeMax()
154155
{

0 commit comments

Comments
 (0)