Skip to content

Remove 3 active issues #59790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Remove 3 active issues #59790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b92fe04
Remove 3 active issues
danmoseley Sep 30, 2021
5717a41
Apply suggestions from code review
danmoseley Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions src/libraries/System.IO.FileSystem/tests/Base/InfoGetSetTimes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,6 @@ public abstract class InfoGetSetTimes<T> : BaseGetSetTimes<T> where T : FileSyst
{
protected abstract void InvokeCreate(T item);

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/30108")]
public void DoesntExistThenCreate_ReturnsDefaultValues()
{
T item = GetMissingItem();
InvokeCreate(item);

Assert.All(TimeFunctions(), (function) =>
{
Assert.Equal(
function.Kind == DateTimeKind.Local
? DateTime.FromFileTime(0).Ticks
: DateTime.FromFileTimeUtc(0).Ticks,
function.Getter(item).Ticks);
});
}

[Fact]
public void ExistsThenDelete_ReturnsDefaultValues()
{
Expand Down
5 changes: 4 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/Directory/EnumerableTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ namespace System.IO.Tests
public class EnumerableTests : FileSystemTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/24295", TestPlatforms.AnyUnix)]
// we don't guarantee thread safety of enumerators in general, but on Windows we
// currently are thread safe, and this test will help ensure that if we change that
// it's a conscious decision. Discussed in https://github.com/dotnet/runtime/issues/24295.
[PlatformSpecific(TestPlatforms.Windows)]
public void FileEnumeratorIsThreadSafe()
{
string directory = Directory.CreateDirectory(GetTestFilePath()).FullName;
Expand Down
3 changes: 2 additions & 1 deletion src/libraries/System.IO.FileSystem/tests/File/GetSetTimes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ public void SetUptoNanoseconds()
Assert.Equal(ticks, dateTime.Ticks);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/43166", TestPlatforms.Linux)]
// Linux kernels no longer have long max date time support. Discussed in https://github.com/dotnet/runtime/issues/43166.
[PlatformSpecific(~TestPlatforms.Linux)]
[ConditionalFact(nameof(SupportsLongMaxDateTime))]
public void SetDateTimeMax()
{
Expand Down