Only build cdac-build-tool when we need to build runtime #109719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs |
am11
reviewed
Nov 12, 2024
src/coreclr/runtime-prereqs.proj
Outdated
| @@ -14,7 +14,7 @@ | |||
| <Import Project="$(RepositoryEngineeringDir)nativepgo.targets" /> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="tools\cdac-build-tool\cdac-build-tool.csproj" ReferenceOutputAssembly="false" /> | |||
| <ProjectReference Condition="'$(ClrRuntimeSubset)' == 'true'" Include="tools\cdac-build-tool\cdac-build-tool.csproj" ReferenceOutputAssembly="false" /> | |||
There was a problem hiding this comment.
There are still some twists and turns in subset mappings to get these right but we can use this, otherwise unused, property:
Suggested change
| <ProjectReference Condition="'$(ClrRuntimeSubset)' == 'true'" Include="tools\cdac-build-tool\cdac-build-tool.csproj" ReferenceOutputAssembly="false" /> | |
| <ProjectReference Condition="'$(ClrDefaultRuntimeBuildSubsets)' != ''" Include="tools\cdac-build-tool\cdac-build-tool.csproj" ReferenceOutputAssembly="false" /> |
There was a problem hiding this comment.
What would this do? From my reading we set ClrDefaultRuntimeBuildSubsets unconditionally. I'm mostly trying to avoid building this for build.sh clr.iltools which is what ILLinker testing needs and doesn't need cdac-build-tool (but currently builds it).
This was referenced Nov 18, 2024
Open
jkoritzinsky
reviewed
Dec 3, 2024
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
This was referenced Dec 4, 2024
jkoritzinsky
approved these changes
Dec 4, 2024
This was referenced Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #109718.