Reference ILVerification projects from ILLink solutions #109718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wasn't able to run ILLink unit tests in VS without doing this. My steps: * build.cmd tools.illink+tools.illinktests * open src\tools\illink.sln in VS * right click Mono.Linker.Tests project and choose Run tests * CS0006 Metadata file 'D:\git\runtime2\artifacts\bin\ILVerification\Debug\ILVerification.dll' could not be found Mono.Linker.Tests D:\git\runtime2\src\tools\illink\test\Mono.Linker.Tests\CSC 1 * Add ILVerification project to the SLN * Try running tests again * MSB3030 Could not copy the file "D:\git\runtime2\artifacts\obj\coreclr\cdac-build-tool\Debug\apphost.exe" because it was not found. Mono.Linker.Tests C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets 5321 * Exclude cdac-build-tool from building unless we need the CoreCLR VM * Try running tests again * Success
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Nov 12, 2024
This was referenced Nov 12, 2024
jtschuster
approved these changes
Nov 12, 2024
|
/ba-g browser tests timing out but this is not a product change |
MichalStrehovsky
added a commit
that referenced
this pull request
Dec 5, 2024
mikelle-rogers
pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
I wasn't able to run ILLink unit tests in VS without doing this. My steps:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to run ILLink unit tests in VS without doing this. My steps:
Cc @dotnet/illink