[release/9.0] [browser][host] Include system environment variables when resolving ASPNETCORE_URLS#107392
Merged
lewing merged 1 commit intorelease/9.0from Sep 10, 2024
Merged
Conversation
github-actions
bot
requested review from
lewing and
pavelsavara
as code owners
ghost
added
the
maraf
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
approved these changes
Sep 5, 2024
lewing
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #107293 to release/9.0
/cc @maraf
Customer Impact
The issue effects customers using
wasmbrowserexperimental template from Visual Studio. Visual Studio generateslaunchSettings.jsonwith generated port numbers. The expected behavior is to use these generated port numbers when starting web server. The actual behavior was that the generated port numbers were ignored, because the environment variable provided by Visual Studio wasn't read.Discovered by internal manual testing and by customer reported on discord.
Regression
Regression from #104557
Testing
Verified manually running the test scenario from Visual Studio
Risk
Low. The affected code is used only by experimental templates.