Skip to content

[browser] host should not forward env variables#104557

Merged
pavelsavara merged 1 commit intodotnet:mainfrom
pavelsavara:browser_dont_forward_variables
Jul 9, 2024
Merged

[browser] host should not forward env variables#104557
pavelsavara merged 1 commit intodotnet:mainfrom
pavelsavara:browser_dont_forward_variables

Conversation

@pavelsavara
Copy link
Copy Markdown
Member

@pavelsavara pavelsavara commented Jul 8, 2024

dotnet host should not forward all OS env variables to browser

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Jul 8, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Jul 8, 2024
@pavelsavara pavelsavara requested a review from maraf July 8, 2024 14:57
@pavelsavara pavelsavara self-assigned this Jul 8, 2024
@ghost ghost added the area-Host label Jul 8, 2024
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@pavelsavara pavelsavara marked this pull request as ready for review July 9, 2024 11:36
@pavelsavara pavelsavara requested a review from lewing as a code owner July 9, 2024 11:36
@pavelsavara pavelsavara requested a review from ilonatommy July 9, 2024 11:36
Copy link
Copy Markdown
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look if we mention it in some docs, possibly for WasmAppHost

@pavelsavara pavelsavara merged commit 9fb2c80 into dotnet:main Jul 9, 2024
@pavelsavara pavelsavara deleted the browser_dont_forward_variables branch July 9, 2024 12:12
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Host os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants