Skip to content

[release/9.0] [browser][host] Include system environment variables when resolving ASPNETCORE_URLS #107392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 1 commit into from
Sep 10, 2024
Merged

[release/9.0] [browser][host] Include system environment variables when resolving ASPNETCORE_URLS #107392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/mono/wasm/host/BrowserHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,14 @@ private async Task RunAsync(ILoggerFactory loggerFactory, CancellationToken toke
debugging: _args.CommonConfig.Debugging);
runArgsJson.Save(Path.Combine(_args.CommonConfig.AppPath, "runArgs.json"));

// Read system environment variables after runArgs.json is saved, so they won't be passed to browser.
// But we need them to correctly read ASPNETCORE_URLS
foreach (DictionaryEntry de in Environment.GetEnvironmentVariables())
{
if (de.Key is not null && de.Value is not null)
envVars[(string)de.Key] = (string)de.Value;
}

string[] urls = (envVars.TryGetValue("ASPNETCORE_URLS", out string? aspnetUrls) && aspnetUrls.Length > 0)
? aspnetUrls.Split(';', StringSplitOptions.RemoveEmptyEntries)
: new string[] { $"http://127.0.0.1:{_args.CommonConfig.HostProperties.WebServerPort}", "https://127.0.0.1:0" };
Expand Down